-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmark for strings find/contains functions #7392
Add gbenchmark for strings find/contains functions #7392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake lgtm
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7392 +/- ##
==============================================
Coverage ? 81.80%
==============================================
Files ? 101
Lines ? 16695
Branches ? 0
==============================================
Hits ? 13658
Misses ? 3037
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
Reference #5698
This creates a gbenchmark for the
cudf::strings::contains
,cudf::strings::find
,cudf::strings::find_multiple
,cudf::strings::starts_with
, andcudf::strings::ends_with
.This also includes some improvements for
starts_with
andends_with
to usestring_view::compare
instead ofstring_view::find
sincecompare
would be more efficient when checking for a string at a specific position. This improved the performance of these two functions by 2-3x on average.