-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groupby scan operations (sort groupby) #7387
Merged
rapids-bot
merged 56 commits into
rapidsai:branch-0.19
from
karthikeyann:fea-groupby_scan
Mar 23, 2021
Merged
Changes from 41 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
e3c6c53
rename sort/groupby.cu to sort/aggregate.cpp
karthikeyann 92414a0
cpp error order instantiation fix
karthikeyann 6e7910f
rename store_result_functor to aggregate_result_functor
karthikeyann ab9daec
add groupby::sort_scan, scan_result_functor
karthikeyann cdc1bb5
add group_cumsum (initial commit, compilable)
karthikeyann 37c3144
Add groupby::scan interface
isVoid dff1268
review comments (jake)
karthikeyann 3d5c022
rename group_cumsum.cu to group_sum_scan.cu
karthikeyann ba8b2bc
groupby sum_scan, add unit tests (null cases)
karthikeyann e4639cc
enable fixed_point for groupby sum_scan
karthikeyann 26c5668
add groupby min_scan, max_scan
karthikeyann 3e097d7
add groupby count_scan
karthikeyann 35085b6
minor test code fix
karthikeyann ff97904
add groupby min_scan, max_scan tests
karthikeyann 62e7dec
add unit test unsupported throw
karthikeyann a4d5a04
add groupby count_scan tests
karthikeyann 8e725db
review comments (davidwendt)
karthikeyann 0d09c0a
include cleanup
karthikeyann 0e1f601
Merge branch 'branch-0.19' of github.com:rapidsai/cudf into fea-group…
karthikeyann 39e1bd6
fix file rename in cmake
karthikeyann 65e7378
indentation fix
karthikeyann 970a054
fix missing file cmake
karthikeyann 5b7ea1c
missing files include cmake
karthikeyann dddfd94
move shift to another PR
karthikeyann 3b588f1
replace device_vector with device_uvector in sort groupby
karthikeyann 837c0f1
replace device_vector const& with device_span<const>
karthikeyann 69cac99
Merge branch 'branch-0.19' of github.com:rapidsai/cudf into fea-group…
karthikeyann f83c5a0
Merge branch 'enh-groupby_uvector_span' of github.com:karthikeyann/cu…
karthikeyann 13bbaf8
replace device_vector const& with device_span
karthikeyann 511d1be
Update cpp/src/groupby/sort/sort_helper.cu
karthikeyann f5d0f5b
use device_span (group_scan.hpp)
karthikeyann 4b5aa41
fix segmentation fault in thrust::copy
karthikeyann 8c375fb
fix zero init in group_label
karthikeyann d9fbda0
Merge branch 'enh-groupby_uvector_span' of github.com:karthikeyann/cu…
karthikeyann 7830260
Apply suggestions from code review (vuule)
karthikeyann 206d463
update copyright year in all files
karthikeyann 8d1bd8a
add mismatch num_rows error test
karthikeyann 42825d3
stylefix
karthikeyann 2175a85
Merge branch 'branch-0.19' of github.com:rapidsai/cudf into fea-group…
karthikeyann 43add1a
fix device_span error
karthikeyann f841f9f
Merge branch 'branch-0.19' of github.com:rapidsai/cudf into fea-group…
karthikeyann 592b26a
in scan don't return sorted grouped values
karthikeyann 003d2f2
Apply suggestions from code review
karthikeyann 9fad1b6
review comments
karthikeyann 216dc09
Merge branch 'fea-groupby_scan' of github.com:karthikeyann/cudf into …
karthikeyann 7c9d18a
dictionary column unsupported
karthikeyann f5e31cb
style fix, include cleanup
karthikeyann 51e505d
remove reduntant tests
karthikeyann 632c62b
address review comments(ttnghia)
karthikeyann 0b3f92a
Revert "address review comments(ttnghia)"
karthikeyann 0998a07
address review comments
karthikeyann 6b7ef34
Merge branch 'branch-0.19' of github.com:rapidsai/cudf into fea-group…
karthikeyann 3902d3d
Apply suggestions from code review (davidwendt)
karthikeyann 118513d
include cleanup
karthikeyann bb5dfd7
update unit test style, type aliases
karthikeyann c8e4b99
more tests cleanup
karthikeyann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the latest guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move it to another PR.