Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix std::exeception catch-by-reference gcc9 compile error #7380

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

davidwendt
Copy link
Contributor

Compile error (for gcc-9) created by change in #7254 as mentioned in the following comment.
#7254 (comment)

Core C++ Guidelines for catching exceptions says to always catch by reference.
Polymorphism is supported only with pointers and references.
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Re-exception-ref

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Feb 12, 2021
@davidwendt davidwendt requested a review from a team as a code owner February 12, 2021 13:58
@davidwendt davidwendt self-assigned this Feb 12, 2021
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@f3bf0e5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7380   +/-   ##
==============================================
  Coverage               ?   82.21%           
==============================================
  Files                  ?      100           
  Lines                  ?    16971           
  Branches               ?        0           
==============================================
  Hits                   ?    13953           
  Misses                 ?     3018           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3bf0e5...b3b81c1. Read the comment docs.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a7927e3 into rapidsai:branch-0.19 Feb 13, 2021
@davidwendt davidwendt deleted the gcc9-catch-by-reference branch February 13, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants