fix Arrow CMake file

[rongou]

With the latest cmake (built from head), it crashes with -DARROW_STATIC_LIB=ON. Adding cmake_minimum_required to match what's in the top-level file.

[jlowe]

This needs to target branch-0.19.

[harrism]

Is there a good reason to force push?

[rongou]

@harrism I had to rebase on branch-0.19.

[kkraus14]

@rongou do you happen to have a stacktrace of how it was crashing? Would like to understand what CMake policy introduced in 3.18+ is giving it issues.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@c0282e6). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             branch-0.19    #7358   +/-   ##
==============================================
  Coverage               ?   82.22%           
==============================================
  Files                  ?      100           
  Lines                  ?    16969           
  Branches               ?        0           
==============================================
  Hits                   ?    13953           
  Misses                 ?     3016           
  Partials               ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0282e6...e014ca3. Read the comment docs.

[rongou]

@kkraus14

CMake Error in CMakeLists.txt:
  No cmake_minimum_required command is present.  A line of code such as

    cmake_minimum_required(VERSION 3.19)

  should be added at the top of the file.  The version specified may be lower
  if you wish to support older CMake versions for this project.  For more
  information run "cmake --help-policy CMP0000".


-- Configuring incomplete, errors occurred!
See also "/home/rou/src/cudf/cpp/build/arrow/CMakeFiles/CMakeOutput.log".
CMake Error at cmake/Modules/ConfigureArrow.cmake:39 (message):
  Configuring Arrow failed: 1
Call Stack (most recent call first):
  CMakeLists.txt:205 (include)

[kkraus14]

@rongou how are you invoking CMake / using the ConfigureArrow module? It should be inheriting the cmake_minimum_required from the parent CMakeLists.txt as far as I know.

[kkraus14]

cc @robertmaynard for visibility

[rongou]

Currently this is done through execute_process (https://github.com/rapidsai/cudf/blob/branch-0.19/cpp/cmake/Modules/ConfigureArrow.cmake#L33). This module can probably use some refactoring, e.g. switching to CPM.

[kkraus14]

🤦 well that explains it. This should be fixed in #7107 then, but this is a good bandaid until then.

Is this broken for 0.18 as well? Does this require a patch for the JNI build to work properly?

[rongou]

This is only a problem if you build cmake from head. I've been testing the cmake nvcc symlink change, thus was using the head version. The current release version of cmake still works. Yeah #7107 would be a more permanent fix.

[kkraus14]

Going to merge this in as is then, thanks!

[kkraus14]

@gpucibot merge