Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cudf::ast Small Refactorings #7352

Merged
merged 7 commits into from
Feb 18, 2021
Merged

cudf::ast Small Refactorings #7352

merged 7 commits into from
Feb 18, 2021

Conversation

codereport
Copy link
Contributor

@codereport codereport commented Feb 9, 2021 •
edited
Loading

While reading/debugging through AST code in order to understand it, I did/am doing a few small refactorings.

@codereport codereport added 2 - In Progress Currently a work in progress code quality libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 9, 2021
@codereport codereport self-assigned this Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@c0282e6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7352   +/-   ##
==============================================
  Coverage               ?   82.21%           
==============================================
  Files                  ?      100           
  Lines                  ?    16971           
  Branches               ?        0           
==============================================
  Hits                   ?    13953           
  Misses                 ?     3018           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0282e6...b52f687. Read the comment docs.

@codereport codereport added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress labels Feb 17, 2021
@codereport codereport marked this pull request as ready for review February 17, 2021 20:18
@codereport codereport requested a review from a team as a code owner February 17, 2021 20:18
jrhemstad
jrhemstad reviewed Feb 18, 2021
View reviewed changes
cpp/src/ast/transform.cu Outdated Show resolved Hide resolved
@codereport codereport requested a review from jrhemstad February 18, 2021 15:21
@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Feb 18, 2021
@codereport
Copy link
Contributor Author

@gpucibot merge

@codereport
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit 593dc1c into rapidsai:branch-0.19 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@cwharris cwharris Awaiting requested review from cwharris

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codereport @jrhemstad @rgsl888prabhu