Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove std::cout and print in the scatter test function EmptyListsOfNullableStrings. #7342

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Remove std::cout and print in the scatter test function EmptyListsOfNullableStrings. #7342

merged 1 commit into from
Feb 9, 2021

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Feb 8, 2021 •
edited
Loading

Remove std::cout and print in the scatter test function EmptyListsOfNullableStrings.

This fixes #7341

@ttnghia ttnghia requested a review from a team as a code owner February 8, 2021 20:37
@ttnghia ttnghia requested review from vuule and davidwendt February 8, 2021 20:37
@ttnghia ttnghia added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. labels Feb 8, 2021
@ttnghia ttnghia requested review from nvdbaranec and removed request for vuule and davidwendt February 8, 2021 20:40
@ttnghia ttnghia added the non-breaking Non-breaking change label Feb 8, 2021
@davidwendt davidwendt added the improvement Improvement / enhancement to an existing function label Feb 8, 2021
@ttnghia ttnghia added the bug Something isn't working label Feb 8, 2021
@vuule vuule removed the bug Something isn't working label Feb 8, 2021
@harrism
Copy link
Member

harrism commented Feb 8, 2021

@gpucibot merge

@codecov
Copy link

codecov bot commented Feb 9, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@eb8dc88). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7342   +/-   ##
==============================================
  Coverage               ?   82.20%           
==============================================
  Files                  ?      100           
  Lines                  ?    16966           
  Branches               ?        0           
==============================================
  Hits                   ?    13947           
  Misses                 ?     3019           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8dc88...249270a. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 9e8bdfc into rapidsai:branch-0.19 Feb 9, 2021
@mythrocks
Copy link
Contributor

Yikes. Thanks for cleaning this up, @ttnghia.

@ttnghia ttnghia self-assigned this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@davidwendt davidwendt davidwendt approved these changes

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ttnghia @harrism @mythrocks @davidwendt @nvdbaranec @vuule