Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cupy array in Dataframe.__setitem__ #7340

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Handle cupy array in Dataframe.__setitem__ #7340

merged 3 commits into from
Feb 8, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #7337

This PR introduces changes to handle cupy array in DataFrame.__setitem__.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Feb 8, 2021
@galipremsagar galipremsagar self-assigned this Feb 8, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner February 8, 2021 05:48
@galipremsagar galipremsagar added the bug Something isn't working label Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@eb8dc88). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7340   +/-   ##
==============================================
  Coverage               ?   82.22%           
==============================================
  Files                  ?      100           
  Lines                  ?    16969           
  Branches               ?        0           
==============================================
  Hits                   ?    13953           
  Misses                 ?     3016           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8dc88...71ba7e5. Read the comment docs.

@galipremsagar galipremsagar changed the title handle cupy array in setitem of dataframe Handle cupy array in setitem of dataframe Feb 8, 2021
@galipremsagar galipremsagar changed the title Handle cupy array in setitem of dataframe Handle cupy array in Dataframe.__setitem__ Feb 8, 2021
shwina
shwina approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Feb 8, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ac02ae3 into rapidsai:branch-0.19 Feb 8, 2021
@galipremsagar galipremsagar linked an issue Feb 8, 2021 that may be closed by this pull request
[BUG] __setitem__ of DataFrame is not accounting for a cupy array #7337
Closed
@galipremsagar galipremsagar mentioned this pull request Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] __setitem__ of DataFrame is not accounting for a cupy array
2 participants
@galipremsagar @shwina