Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cudf::detail::make_counting_transform_iterator #7338

Merged
merged 7 commits into from
Feb 9, 2021

Conversation

codereport
Copy link
Contributor

Came across some "raw" uses of thrust::make_transform_iterator + thrust::make_counting_iterator where now cudf::detail::make_counting_transform_iterator can be used (because of #6546).

@codereport codereport added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 6, 2021
@codereport codereport self-assigned this Feb 6, 2021
@codereport codereport requested a review from a team as a code owner February 6, 2021 23:05
@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@366573d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7338   +/-   ##
==============================================
  Coverage               ?   82.22%           
==============================================
  Files                  ?      100           
  Lines                  ?    16969           
  Branches               ?        0           
==============================================
  Hits                   ?    13953           
  Misses                 ?     3016           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366573d...173ac42. Read the comment docs.

@codereport
Copy link
Contributor Author

rerun tests

cpp/include/cudf/detail/iterator.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/detail/iterator.cuh Outdated Show resolved Hide resolved
@codereport codereport requested a review from davidwendt February 8, 2021 22:46
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, except the cases where you replace transform(constant) with transform(counting).

cpp/include/cudf/detail/iterator.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/detail/iterator.cuh Outdated Show resolved Hide resolved
@codereport codereport requested a review from harrism February 8, 2021 23:34
@harrism
Copy link
Member

harrism commented Feb 8, 2021

@gpucibot merge

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Feb 9, 2021
@rapids-bot rapids-bot bot merged commit c0282e6 into rapidsai:branch-0.19 Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants