Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API for LIstMethods.len() #7283

Merged
merged 6 commits into from
Feb 4, 2021
Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 2, 2021

Closes #7157

This PR adds ListMethods.len() API that returns an integer column that contains the length for each element in a ListColumn.
Example:

>>> s = cudf.Series([[1,2], None, [3]])
>>> s
0    [1, 2]
1      None
2       [3]
dtype: list
>>> s.list.len()
0       2
1    <NA>
2       1
dtype: int32

@isVoid isVoid requested a review from a team as a code owner February 2, 2021 19:54
@isVoid isVoid marked this pull request as draft February 2, 2021 19:54
@isVoid isVoid changed the base branch from branch-0.18 to branch-0.19 February 2, 2021 19:55
@isVoid isVoid marked this pull request as ready for review February 2, 2021 21:06
@isVoid isVoid added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. feature request New feature or request non-breaking Non-breaking change labels Feb 2, 2021
@shwina shwina requested a review from kkraus14 February 2, 2021 21:11
@isVoid isVoid removed request for shwina and kkraus14 February 2, 2021 21:11
@shwina shwina requested a review from kkraus14 February 2, 2021 21:11
python/cudf/cudf/_lib/lists.pyx Show resolved Hide resolved
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@3ecde9d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7283   +/-   ##
==============================================
  Coverage               ?   81.78%           
==============================================
  Files                  ?      100           
  Lines                  ?    16594           
  Branches               ?        0           
==============================================
  Hits                   ?    13572           
  Misses                 ?     3022           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ecde9d...011a37d. Read the comment docs.

@kkraus14
Copy link
Collaborator

kkraus14 commented Feb 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7fd069e into rapidsai:branch-0.19 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants