Improve assert_eq handling of scalar
#7220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7220 +/- ##
===============================================
+ Coverage 82.09% 82.20% +0.11%
===============================================
Files 97 100 +3
Lines 16474 16952 +478
===============================================
+ Hits 13524 13936 +412
- Misses 2950 3016 +66
Continue to review full report at Codecov.
|
galipremsagar
approved these changes
Jan 27, 2021
|
rerun tests |
brandon-b-miller
approved these changes
Jan 29, 2021
Co-authored-by: brandon-b-miller <[email protected]>
galipremsagar
added
5 - Ready to Merge
|
rerun tests |
|
@gpucibot merge |
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7199
Refactors scalar handling inside
assert_eq. On higher level, this PR proposes a "whitelist" style testing: all compares should go to the "strict equal" code path unless explicitly allowed. This allows the test system to capture all unintended inequality except the ones that's discussed upon. For example, this PR creates two whitelist items:__eq__, use it to determine equality.For all other cases, the operands should be strictly equal. Note that for testing purposes,
np.nanare considered equal to itself.