Remove floating point types from radix sort fast-path #7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
davidwendt
changed the title
jrhemstad
approved these changes
Jan 26, 2021
codereport
approved these changes
Jan 26, 2021
Comment on lines
+52
to
+54
| // A non-stable sort on a column of arithmetic type with no nulls will use a radix sort | ||
| // if specifying only the `thrust::less` or `thrust::greater` comparators. | ||
| // But this also requires making a copy of the input data. |
kkraus14
added
5 - Ready to Merge
|
I reran the tests that we saw failing and this has fixed them. Thanks. |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7215 +/- ##
===============================================
+ Coverage 82.09% 82.20% +0.11%
===============================================
Files 97 98 +1
Lines 16474 16692 +218
===============================================
+ Hits 13524 13722 +198
- Misses 2950 2970 +20
Continue to review full report at Codecov.
|
davidwendt
added
5 - Ready to Merge
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
PR #7215 removed single floating point columns from radix sort fast-path but missed disabling the fast-path sort for floating-point in `cudf::sort()`. This PR fixes `cudf::sort` and adds a new test to the existing `RowOperatorTestForNAN.NANSortingNonNull` gtest. Authors: - David (@davidwendt) Approvers: - Ram (Ramakrishna Prabhu) (@rgsl888prabhu) - Conor Hoekstra (@codereport) URL: #7250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7212
Reference #7167 (comment)
Using radix sort for all fixed-width types causes an error in Spark when floating point columns contain NaN elements.
This PR removes floating-point column types from the radix fast-path. This means the original
relational_comparerow operator is used to handle sorting floating point columns since they could possibly contain NaN elements.The
NANSortinggtest included null elements so it did not catch the fast-path output discrepancy. This PR adds aNANSortingNonNullgtest to check for the desired NaN sorting behavior.