Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix importing list & struct types in from_arrow #7162

Merged
merged 9 commits into from
Jan 20, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jan 16, 2021

Fixes: #7137, #7148

This PR fixes converting a pyarrow table which has llist and struct types via from_arrow. Incase of list dtype we shouldn't have to perform any typecast and incase of struct dtype we should be renaming the fields appropriately.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Jan 16, 2021
@galipremsagar galipremsagar self-assigned this Jan 16, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner January 16, 2021 02:43
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have a small query. And need to update copyright year.

python/cudf/cudf/core/frame.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #7162 (1f79802) into branch-0.18 (8860baf) will increase coverage by 0.04%.
The diff coverage is 76.78%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7162      +/-   ##
===============================================
+ Coverage        82.09%   82.14%   +0.04%     
===============================================
  Files               97       97              
  Lines            16474    16542      +68     
===============================================
+ Hits             13524    13588      +64     
- Misses            2950     2954       +4     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 91.66% <ø> (-0.09%) ⬇️
python/cudf/cudf/core/dataframe.py 90.71% <50.00%> (+<0.01%) ⬆️
python/cudf/cudf/io/orc.py 86.80% <60.00%> (-1.61%) ⬇️
python/cudf/cudf/core/dtypes.py 89.50% <66.66%> (-0.88%) ⬇️
python/cudf/cudf/io/csv.py 90.74% <77.77%> (-2.60%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.17% <80.00%> (-0.24%) ⬇️
python/cudf/cudf/core/series.py 91.10% <80.00%> (-0.06%) ⬇️
python/cudf/cudf/core/reshape.py 91.00% <81.81%> (-0.04%) ⬇️
python/cudf/cudf/core/column/string.py 86.65% <100.00%> (ø)
python/cudf/cudf/core/frame.py 90.01% <100.00%> (+0.03%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0af46...1f79802. Read the comment docs.

Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge labels Jan 20, 2021
@rapids-bot rapids-bot bot merged commit 0515a42 into rapidsai:branch-0.18 Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
3 participants