-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix importing list & struct types in from_arrow
#7162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have a small query. And need to update copyright year.
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7162 +/- ##
===============================================
+ Coverage 82.09% 82.14% +0.04%
===============================================
Files 97 97
Lines 16474 16542 +68
===============================================
+ Hits 13524 13588 +64
- Misses 2950 2954 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #7137, #7148
This PR fixes converting a pyarrow table which has llist and struct types via
from_arrow
. Incase oflist
dtype we shouldn't have to perform any typecast and incase ofstruct
dtype we should be renaming the fields appropriately.