Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cudf::round for fixed_point when scale = -decimal_places a no-op #6975

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

codereport
Copy link
Contributor

@nartal1 found a small bug while working on: NVIDIA/spark-rapids#1244

Problem is that for fixed_point, when the column scale = -decimal_places, it should be a no-op. Fix is to make it a no-op.

@codereport codereport added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change labels Dec 10, 2020
@codereport codereport self-assigned this Dec 10, 2020
@codereport codereport requested a review from a team as a code owner December 10, 2020 20:47
@codereport codereport added 6 - Okay to Auto-Merge and removed 4 - Needs Review Waiting for reviewer to review or respond labels Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #6975 (da7d13e) into branch-0.18 (89938fa) will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #6975      +/-   ##
===============================================
+ Coverage        81.59%   82.01%   +0.42%     
===============================================
  Files               96       96              
  Lines            15905    16267     +362     
===============================================
+ Hits             12978    13342     +364     
+ Misses            2927     2925       -2     
Impacted Files Coverage Δ
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 98.74% <0.00%> (+0.02%) ⬆️
python/cudf/cudf/core/join/join.py 92.44% <0.00%> (+0.03%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89938fa...da7d13e. Read the comment docs.

@harrism
Copy link
Member

harrism commented Dec 11, 2020

The title of this PR reads like an issue title. For the sake of the changelog, can you please rewrite it to reflect what the PR does?

@codereport codereport changed the title cudf::round for fixed_point when scale = -decimal_places should be no-op Make cudf::round for fixed_point when scale = -decimal_places a no-op Dec 11, 2020
@rapids-bot rapids-bot bot merged commit 13acc98 into rapidsai:branch-0.18 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants