[REVIEW] ignore list dtypes for select_dtype, similar to pandas #6928
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
harrism
changed the title
|
ok to test |
1 similar comment
|
ok to test |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6928 +/- ##
===============================================
- Coverage 81.95% 81.94% -0.01%
===============================================
Files 96 96
Lines 16294 16291 -3
===============================================
- Hits 13353 13350 -3
Misses 2941 2941
Continue to review full report at Codecov.
|
| @@ -6741,7 +6741,7 @@ def select_dtypes(self, include=None, exclude=None): | |||
| # category handling | |||
| if is_categorical_dtype(i_dtype): | |||
| include_subtypes.add(i_dtype) | |||
| elif issubclass(dtype.type, i_dtype): | |||
| elif type(dtype.type) == type and issubclass(dtype.type, i_dtype): | |||
There was a problem hiding this comment.
How does this change exclude list types specifically?
|
Given this PR has gone stale I'm going to close it. @jpurviance if you're interested in updating this please open a new PR targeted at |
Closes #6919
Prevents select dtypes failure when list dyptes are in dataframe. Follows pandas API.