-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing clone overrides on derived aggregations #6898
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this.
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6898 +/- ##
===============================================
- Coverage 82.31% 81.96% -0.36%
===============================================
Files 93 96 +3
Lines 15358 16231 +873
===============================================
+ Hits 12642 13303 +661
- Misses 2716 2928 +212
Continue to review full report at Codecov.
|
Great catch. |
Fixes #6891
Adds missing
clone()
overrides on aggregations that are derived but do not usederived_aggregation
.