Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JNI build [skip ci] #6824

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix JNI build [skip ci] #6824

merged 2 commits into from
Nov 20, 2020

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Nov 20, 2020

This fixes the JNI build after #6648. The JNI data_sink was updated to use RMM stream views before the data_sink API was updated.

@jlowe jlowe added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer labels Nov 20, 2020
@jlowe jlowe requested a review from a team as a code owner November 20, 2020 21:57
@jlowe jlowe self-assigned this Nov 20, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@jlowe
Copy link
Member Author

jlowe commented Nov 20, 2020

Unfortunately an override directive was missing from the derived JNI data_sink class or this would have been caught when @harrism did the Java build. This change will need to be reverted as part of #6744, but it unblocks the Java build in the interim.

@jlowe jlowe merged commit 5380744 into rapidsai:branch-0.17 Nov 20, 2020
@harrism
Copy link
Member

harrism commented Nov 22, 2020

I added the override in #6744. Please review that PR. Thanks!

@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhushukla kuhushukla kuhushukla approved these changes

Assignees

@jlowe jlowe

Labels
4 - Needs Review Waiting for reviewer to review or respond Java Affects Java cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlowe @GPUtester @harrism @kuhushukla @vyasr