Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize child column construction in scatter() for lists columns #6791

Closed
wants to merge 10 commits into from
Closed

Parallelize child column construction in scatter() for lists columns #6791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5741f69
[scatter<list>] Initial impl:
mythrocks Nov 3, 2020
3cac246
[scatter<list>] Minor refactoring:
mythrocks Nov 14, 2020
bce24b4
[scatter<list>] Changelog, + clang-format.
mythrocks Nov 15, 2020
a7dc525
[scatter<list>] Switch to rmm::cuda_stream_view
mythrocks Nov 16, 2020
c764de2
[scatter<list>] Move label_t to scoped label_type
mythrocks Nov 16, 2020
b1caeef
[scatter<list>] Switch from device_vector to device_uvector.
mythrocks Nov 16, 2020
2da4f15
[scatter<list>] Fix documentation. Switch size types to size_type.
mythrocks Nov 16, 2020
09325c7
[scatter<list>] Fix documentation.
mythrocks Nov 16, 2020
4b6a54f
[scatter<list>] More documentation fixes, const correctness
mythrocks Nov 16, 2020
6931ac8
[scatter<list>] Optimize for parallel child column construction:
mythrocks Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- PR #6638 Add support for `pipe` API
- PR #6675 Add DecimalDtype to cuDF
- PR #6739 Add Java bindings for is_timestamp
- PR #6768 Add support for scatter() on list columns

## Improvements

Expand Down
15 changes: 15 additions & 0 deletions cpp/include/cudf/detail/scatter.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <cudf/dictionary/detail/update_keys.hpp>
#include <cudf/dictionary/dictionary_column_view.hpp>
#include <cudf/dictionary/dictionary_factories.hpp>
#include <cudf/lists/detail/scatter.cuh>
#include <cudf/strings/detail/scatter.cuh>
#include <cudf/strings/string_view.cuh>
#include <cudf/utilities/traits.hpp>
Expand Down Expand Up @@ -118,6 +119,20 @@ struct column_scatterer_impl<string_view, MapIterator> {
}
};

template <typename MapIterator>
struct column_scatterer_impl<list_view, MapIterator> {
std::unique_ptr<column> operator()(column_view const& source,
MapIterator scatter_map_begin,
MapIterator scatter_map_end,
column_view const& target,
rmm::mr::device_memory_resource* mr,
cudaStream_t stream) const
{
return cudf::lists::detail::scatter(
source, scatter_map_begin, scatter_map_end, target, stream, mr);
}
};

template <typename MapIterator>
struct column_scatterer {
template <typename Element>
Expand Down
Loading