-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add dictionary support to cudf::minmax #6764
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6764 +/- ##
===============================================
+ Coverage 81.71% 82.42% +0.71%
===============================================
Files 96 96
Lines 15978 16843 +865
===============================================
+ Hits 13056 13883 +827
- Misses 2922 2960 +38
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized something. Not requesting changes because need confirmation if what I'm thinking is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-dealbreaker comment but approve otherwise.
Reference #5963
Add support for dictionary column types in
cudf::minmax
. This PR also adds support for strings column types as well. The code was refactored to re-use the internalreduce_device
function for all supported types. The strings specialization logic just creates astring_scalar
result which requires a copy step to build a newstring_scalar
object from astring_view
(output from thereduce_device
function). The dictionary support was to just to substitute thekeys()
column in the detail function right before the type-dispatcher call.Added a gtests for strings as well as dictionary with strings keys.