Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Apply na_rep to column names in csv writer #6708

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

galipremsagar
Copy link
Contributor

Fixes: #6688

na_rep was not being applied to column names, column names can be None too. So this PR introduces changes that will apply na_rep for column names as well.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Nov 9, 2020
@galipremsagar galipremsagar requested a review from a team as a code owner November 9, 2020 01:53
@galipremsagar galipremsagar self-assigned this Nov 9, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #6708 (f61aa12) into branch-0.17 (24dcc8e) will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #6708      +/-   ##
===============================================
+ Coverage        82.18%   82.46%   +0.28%     
===============================================
  Files               94       94              
  Lines            15467    15797     +330     
===============================================
+ Hits             12711    13027     +316     
- Misses            2756     2770      +14     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 91.58% <0.00%> (+0.55%) ⬆️
python/cudf/cudf/core/abc.py 91.48% <0.00%> (+4.25%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 58.53% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dcc8e...f61aa12. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

rerun tests

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Nov 9, 2020
@galipremsagar galipremsagar merged commit 3bd593d into rapidsai:branch-0.17 Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] csv writer parameter na_rep is not being applied to column names
3 participants