Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repo URL from Java build-info [skip ci] #6491

Merged
merged 4 commits into from
Oct 12, 2020

Conversation

NvTimLiu
Copy link
Contributor

Issue #6490

**Describe the bug
There is an offensive word in the cuDF java binaries.

Steps/Code to reproduce bug
Our cuDF java binaries are built from the source code of nvspark/cudf Gitlab repo, which is the down-stream of this GitHub rapidsai/cudf.

When building cuDF java binaries, the build-info is collected via the script java/buildscripts/build-info.

In this build-info (an example showing as below), the down-stream repo URL contains the offensive word.

version=0.16-SNAPSHOT
user=
revision=9ec5093e18dcea3978931288d14f0476b58347ae
branch=HEAD
date=2020-09-27T03:53:03Z
url=https://gitlab-master.nvidia.com/nvspark/cudf.git
This build-info will be packaged into the cuDF binaries, and be released onto public maven repo.

Expected behavior
cuDF java binaries should not have any offensive word.

Remove down-stream repo URL from build-info.

@NvTimLiu NvTimLiu requested a review from a team as a code owner October 12, 2020 12:12
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@NvTimLiu NvTimLiu self-assigned this Oct 12, 2020
@jlowe jlowe changed the title Remove repo url from build-info, as it contains offensive word Remove repo URL from Java build-info Oct 12, 2020
@jlowe jlowe added the Java Affects Java cuDF API. label Oct 12, 2020
@jlowe
Copy link
Contributor

jlowe commented Oct 12, 2020

Looks OK except CHANGELOG.md needs to be updated.

@jlowe jlowe changed the title Remove repo URL from Java build-info Remove repo URL from Java build-info [skip ci] Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #6491 into branch-0.16 will decrease coverage by 1.47%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #6491      +/-   ##
===============================================
- Coverage        84.45%   82.97%   -1.48%     
===============================================
  Files               82       95      +13     
  Lines            13846    14900    +1054     
===============================================
+ Hits             11694    12364     +670     
- Misses            2152     2536     +384     
Impacted Files Coverage Δ
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-4.26%) ⬇️
python/dask_cudf/dask_cudf/io/orc.py 90.90% <0.00%> (-1.28%) ⬇️
python/dask_cudf/dask_cudf/io/parquet.py 91.35% <0.00%> (-0.85%) ⬇️
python/cudf/cudf/utils/cudautils.py 48.55% <0.00%> (-0.74%) ⬇️
python/cudf/cudf/_version.py 44.80% <0.00%> (-0.72%) ⬇️
python/cudf/cudf/core/frame.py 89.86% <0.00%> (-0.53%) ⬇️
python/cudf/cudf/io/parquet.py 91.73% <0.00%> (-0.50%) ⬇️
python/dask_cudf/dask_cudf/core.py 75.64% <0.00%> (-0.26%) ⬇️
python/cudf/cudf/core/column/categorical.py 93.11% <0.00%> (-0.26%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 793baa0...d6f104c. Read the comment docs.

@NvTimLiu
Copy link
Contributor Author

Looks OK except CHANGELOG.md needs to be updated.

@jlowe Thanks for your review, updated CHANGELOG.md

@jlowe jlowe merged commit 421fddb into rapidsai:branch-0.16 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Affects Java cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants