-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove repo URL from Java build-info [skip ci] #6491
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Looks OK except |
Codecov Report
@@ Coverage Diff @@
## branch-0.16 #6491 +/- ##
===============================================
- Coverage 84.45% 82.97% -1.48%
===============================================
Files 82 95 +13
Lines 13846 14900 +1054
===============================================
+ Hits 11694 12364 +670
- Misses 2152 2536 +384
Continue to review full report at Codecov.
|
@jlowe Thanks for your review, updated |
Issue #6490
**Describe the bug
There is an offensive word in the cuDF java binaries.
Steps/Code to reproduce bug
Our cuDF java binaries are built from the source code of nvspark/cudf Gitlab repo, which is the down-stream of this GitHub rapidsai/cudf.
When building cuDF java binaries, the build-info is collected via the script java/buildscripts/build-info.
In this build-info (an example showing as below), the down-stream repo URL contains the offensive word.
version=0.16-SNAPSHOT
user=
revision=9ec5093e18dcea3978931288d14f0476b58347ae
branch=HEAD
date=2020-09-27T03:53:03Z
url=https://gitlab-master.nvidia.com/nvspark/cudf.git
This build-info will be packaged into the cuDF binaries, and be released onto public maven repo.
Expected behavior
cuDF java binaries should not have any offensive word.
Remove down-stream repo URL from build-info.