Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add AVRO fuzz tests with varying function parameters #6489

Merged
merged 19 commits into from
Oct 30, 2020
Merged

[REVIEW] Add AVRO fuzz tests with varying function parameters #6489

merged 19 commits into from
Oct 30, 2020

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Oct 11, 2020 •
edited
Loading

Partially addresses: #6001 , #6260

This PR:

  • Adds support for Avro fuzz worker
  • Utilize fastavro to write/create avro files.
  • Add varying test parameter combinations for cudf.read_avro

This is ready for review but dependent on #6384 for cudf._fuzz_testing.utils.compare_dataframe API

@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. labels Oct 11, 2020
@galipremsagar galipremsagar self-assigned this Oct 11, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@galipremsagar galipremsagar changed the title [WIP] Add Avro fuzz tests [REVIEW] Add AVRO fuzz tests with varying function parameters Oct 14, 2020
@galipremsagar galipremsagar added 0 - Blocked Cannot progress due to external reasons 5 - Merge After Dependencies 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 14, 2020
@galipremsagar galipremsagar marked this pull request as ready for review October 14, 2020 17:34
@galipremsagar galipremsagar requested a review from a team as a code owner October 14, 2020 17:34
@codecov
Copy link

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #6489 into branch-0.17 will decrease coverage by 0.47%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #6489      +/-   ##
===============================================
- Coverage        82.67%   82.20%   -0.48%     
===============================================
  Files               91       92       +1     
  Lines            15103    15197      +94     
===============================================
+ Hits             12486    12492       +6     
- Misses            2617     2705      +88
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/avro.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 86.44% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6f0cc...34622e4. Read the comment docs.

@galipremsagar galipremsagar mentioned this pull request Oct 21, 2020
Merged
3 tasks
@galipremsagar galipremsagar changed the title [REVIEW] Add AVRO fuzz tests with varying function parameters [WIP] Add AVRO fuzz tests with varying function parameters Oct 27, 2020
@galipremsagar galipremsagar removed the 3 - Ready for Review Ready for review by team label Oct 27, 2020
@vuule vuule self-requested a review October 29, 2020 17:17
brandon-b-miller
brandon-b-miller requested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - left a couple of questions/comments.

@galipremsagar galipremsagar changed the title [REVIEW] Add AVRO fuzz tests with varying function parameters [WIP] Add AVRO fuzz tests with varying function parameters Oct 30, 2020
@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Oct 30, 2020
@galipremsagar galipremsagar changed the title [WIP] Add AVRO fuzz tests with varying function parameters [REVIEW] Add AVRO fuzz tests with varying function parameters Oct 30, 2020
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Oct 30, 2020
@galipremsagar galipremsagar merged commit b2f875d into rapidsai:branch-0.17 Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vuule vuule vuule approved these changes

@isVoid isVoid Awaiting requested review from isVoid

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @GPUtester @brandon-b-miller @vuule