[REVIEW] Fix/read parquet for empty DataFrame #6294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-empty series. Changed test so dtypes for empty series are ignored.
… when axis=1 and ignore_index=True.
…ithub.com/marlenezw/cudf into feature/concat_empty_and_non_empty_series I'd like to merge my remote branch with my local branch
…-empty series. Changed test so dtypes for empty series are ignored.
… when axis=1 and ignore_index=True.
Added this file by mistake from the old 0.14 cudf branch. Deleting it because it is not in the current branch.
…om/marlenezw/cudf into fix/output_based_on_dtype_for_acos I'd like to pull in my origin branch changes
Codecov Report
@@ Coverage Diff @@
## branch-0.16 #6294 +/- ##
===============================================
+ Coverage 83.16% 83.18% +0.02%
===============================================
Files 90 90
Lines 14692 14693 +1
===============================================
+ Hits 12218 12222 +4
+ Misses 2474 2471 -3
Continue to review full report at Codecov.
|
…ix/read_parquet_for_empty_dataframe
marlenezw
changed the title
marlenezw
added
3 - Ready for Review
kkraus14
requested changes
Sep 24, 2020
kkraus14
reviewed
Sep 24, 2020
added 2 commits
September 24, 2020 10:18
…ix/read_parquet_for_empty_dataframe
kkraus14
reviewed
Sep 24, 2020
…ix/read_parquet_for_empty_dataframe
kkraus14
approved these changes
Sep 25, 2020
kkraus14
added
5 - Ready to Merge
cwharris
pushed a commit
to cwharris/cudf
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit Closes #6167
I've added a try/except statement in parquet.pyx and updated the unit tests in parquet.py. This stops a Key error from appearing when a parquet file is created from an empty pandas data frame and then read using cudf.