Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] use the CUB submodule in Thrust instead of fetching it #6155

Merged
merged 5 commits into from
Sep 8, 2020

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Sep 4, 2020

@rongou rongou requested a review from a team as a code owner September 4, 2020 00:09
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #6155 into branch-0.16 will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #6155      +/-   ##
===============================================
+ Coverage        84.20%   84.53%   +0.32%     
===============================================
  Files               82       82              
  Lines            13575    13916     +341     
===============================================
+ Hits             11431    11764     +333     
- Misses            2144     2152       +8     
Impacted Files Coverage Δ
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/custreamz/custreamz/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/custreamz/custreamz/tests/test_dataframes.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 98.75% <0.00%> (+0.02%) ⬆️
python/cudf/cudf/core/join/join.py 92.41% <0.00%> (+0.03%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19237a0...59adc06. Read the comment docs.

@harrism harrism added the 3 - Ready for Review Ready for review by team label Sep 7, 2020
@kkraus14 kkraus14 added the CMake CMake build issue label Sep 8, 2020
@kkraus14
Copy link
Collaborator

kkraus14 commented Sep 8, 2020

rerun tests

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 8, 2020
@harrism harrism merged commit f4735c7 into rapidsai:branch-0.16 Sep 8, 2020
@rongou rongou deleted the no-fetch-cub branch October 9, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants