Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add support for numpy RandomState handling in sample #6128

Conversation

rgsl888prabhu
Copy link
Contributor

closes #6127

@rgsl888prabhu rgsl888prabhu added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Aug 31, 2020
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner August 31, 2020 17:14
@rgsl888prabhu rgsl888prabhu self-assigned this Aug 31, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@rgsl888prabhu
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #6128 into branch-0.16 will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #6128      +/-   ##
===============================================
+ Coverage        84.46%   84.48%   +0.02%     
===============================================
  Files               82       82              
  Lines            13852    13886      +34     
===============================================
+ Hits             11700    11732      +32     
- Misses            2152     2154       +2     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 90.31% <83.33%> (-0.07%) ⬇️
python/cudf/cudf/utils/ioutils.py 85.84% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 92.43% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10aab18...2773167. Read the comment docs.

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 31, 2020
@rgsl888prabhu
Copy link
Contributor Author

rerun tests

@rgsl888prabhu rgsl888prabhu merged commit 0d83d64 into rapidsai:branch-0.16 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] dask_cudf sample not working (TypeError)
4 participants