Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix typo in column_buffer.hpp docs [skip-ci] #6063

Closed
wants to merge 1 commit into from
Closed

[REVIEW] Fix typo in column_buffer.hpp docs [skip-ci] #6063

wants to merge 1 commit into from

Conversation

goodengineer
Copy link

small typo fix

@goodengineer goodengineer requested a review from a team as a code owner August 21, 2020 05:04
@goodengineer goodengineer requested review from harrism and vuule August 21, 2020 05:04
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@harrism harrism changed the base branch from branch-0.15 to branch-0.16 August 21, 2020 05:05
@harrism harrism added doc Documentation libcudf Affects libcudf (C++/CUDA) code. labels Aug 21, 2020
@harrism
Copy link
Member

harrism commented Aug 21, 2020

@goodengineer thanks for the contribution. We are in the middle of a release (v0.15), so I've retargeted this PR to the next release branch (branch-0.16).

@harrism harrism changed the title Update column_buffer.hpp [REVIEW] Update column_buffer.hpp [skip-ci] Aug 21, 2020
@harrism harrism added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 21, 2020
@harrism harrism changed the title [REVIEW] Update column_buffer.hpp [skip-ci] [REVIEW] Fix typo in column_buffer.hpp docs [skip-ci] Aug 21, 2020
@harrism harrism mentioned this pull request Aug 21, 2020
Closed
@kkraus14 kkraus14 added 0 - Waiting on Author Waiting for author to respond to review and removed 5 - Ready to Merge Testing and reviews complete, ready to merge labels Aug 21, 2020
@kkraus14
Copy link
Collaborator

@goodengineer please add an entry in https://github.com/rapidsai/cudf/blob/branch-0.16/CHANGELOG.md as well as the other typo fix from #6064 and I'll merge, thanks!

@harrism
Copy link
Member

harrism commented Oct 6, 2020

I don't think we want to clutter the changelog with this. It's already more work than its worth for a single-word doc change.

@harrism
Copy link
Member

harrism commented Oct 6, 2020

On the other hand I can't even admin merge it.

@kkraus14
Copy link
Collaborator

kkraus14 commented Oct 6, 2020

On the other hand I can't even admin merge it.

There was an ask made to combine the typo fixes in #6064 into here that we were waiting on before merging.

@harrism harrism mentioned this pull request Oct 8, 2020
Closed
@harrism
Copy link
Member

harrism commented Oct 11, 2020

This has been incorporated into #5861

@harrism harrism closed this Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@harrism harrism harrism approved these changes

@vuule vuule Awaiting requested review from vuule

Assignees
No one assigned
Labels
0 - Waiting on Author Waiting for author to respond to review doc Documentation libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@goodengineer @GPUtester @harrism @kkraus14 @davidwendt