Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix jitcache-multiprocess test failure, fix CUDA 11 related CI issues #5942

Merged
merged 9 commits into from
Aug 12, 2020

Conversation

harrism
Copy link
Member

@harrism harrism commented Aug 12, 2020

Recent changes to rmm::mr::get_default_resource() caused the CUDA context
to be created in the JITCACHE_MULTIPROCESS_TEST before the child process is
forked, which caused the child to not get a context. This PR fixes the failure.

@harrism harrism added 3 - Ready for Review Ready for review by team tests Unit testing for project cuda libcudf Affects libcudf (C++/CUDA) code. labels Aug 12, 2020
@harrism harrism requested a review from a team as a code owner August 12, 2020 07:24
@harrism harrism changed the title [REVIEW} Fix jitcache-multiprocess test failure [REVIEW] Fix jitcache-multiprocess test failure Aug 12, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #5942 into branch-0.15 will decrease coverage by 4.21%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #5942      +/-   ##
===============================================
- Coverage        88.65%   84.43%   -4.22%     
===============================================
  Files               57       80      +23     
  Lines            10945    13424    +2479     
===============================================
+ Hits              9703    11335    +1632     
- Misses            1242     2089     +847     
Impacted Files Coverage Δ
python/cudf/cudf/core/dtypes.py 86.84% <0.00%> (-10.09%) ⬇️
python/cudf/cudf/core/abc.py 91.48% <0.00%> (-2.96%) ⬇️
python/cudf/cudf/core/frame.py 89.76% <0.00%> (-1.42%) ⬇️
python/cudf/cudf/utils/ioutils.py 86.13% <0.00%> (-1.21%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 93.12% <0.00%> (-0.99%) ⬇️
python/cudf/cudf/core/indexing.py 95.22% <0.00%> (-0.68%) ⬇️
python/cudf/cudf/utils/dtypes.py 85.89% <0.00%> (-0.54%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 93.18% <0.00%> (-0.10%) ⬇️
python/cudf/cudf/io/avro.py 81.81% <0.00%> (ø)
python/cudf/cudf/core/ops.py 77.58% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231edac...7b80c4e. Read the comment docs.

@galipremsagar
Copy link
Contributor

rerun tests

CHANGELOG.md Show resolved Hide resolved
@kkraus14 kkraus14 changed the title [REVIEW] Fix jitcache-multiprocess test failure [REVIEW] Fix jitcache-multiprocess test failure, fix CUDA 11 related CI issues Aug 12, 2020
@harrism harrism requested a review from a team as a code owner August 12, 2020 18:09
@harrism harrism requested a review from a team as a code owner August 12, 2020 19:07
Copy link
Contributor

@devavret devavret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jitcache changes LGTM

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 12, 2020
@kkraus14 kkraus14 merged commit 82e6b27 into rapidsai:branch-0.15 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge libcudf Affects libcudf (C++/CUDA) code. tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants