Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] fixed_point Column Optimization (store scale in data_type) [skip ci] #5861

Merged
merged 178 commits into from
Oct 13, 2020
Merged
Changes from 1 commit
Commits
Show all changes
178 commits
Select commit Hold shift + click to select a range
704ed80
Add fixed_point iterator test
trevorsm7 May 23, 2020
787876a
Add test demonstrating binary op
trevorsm7 May 23, 2020
de6921b
Replace cout with asserts
trevorsm7 May 23, 2020
4046257
Test with fraction fixed_point values
trevorsm7 May 23, 2020
bcb4f69
Attempt to implement proxy reference, but thrust doesn't like it
trevorsm7 May 27, 2020
1375e0b
Add hacked up transform_mutable_iterator
trevorsm7 May 27, 2020
995ce9c
Cleanup dead code
trevorsm7 May 27, 2020
8a95e1b
Actually make mutable iterator work as input iterator
trevorsm7 May 28, 2020
c88f400
Simplify diff from transform_output_iterator
trevorsm7 May 28, 2020
b0fe2bf
Add device implementation of fixed point iterator
trevorsm7 May 28, 2020
a4e266a
Add test with iterator random access in kernel
trevorsm7 May 29, 2020
001f21d
Merge remote-tracking branch 'rapidsai/branch-0.15' into test-fixed-p…
trevorsm7 Jul 15, 2020
889baf0
Use thrust/transform_input_output_iterator
trevorsm7 Jul 15, 2020
5fa4617
Replace rescale with rescaled
trevorsm7 Jul 15, 2020
ed70d68
Add constexpr to numeric::scale_type ctor
codereport Aug 5, 2020
9101b2b
Cleanup forward declarations
codereport Aug 5, 2020
13858b2
Add scale to data_type
codereport Aug 5, 2020
809f00e
Fixed typo in clamp file
codereport Aug 5, 2020
aecc533
Merge branch 'branch-0.15' into fp-scale-to-datatype
codereport Aug 6, 2020
5b7cbec
Add make_numeric_column
codereport Aug 6, 2020
6e2bf32
factories_test.cpp remove FixedWidthTypesWithoutFixedPoint
codereport Aug 6, 2020
5a12de7
Update CHANGELOG
codereport Aug 6, 2020
968182e
Merge branch 'branch-0.15' into fp-scale-to-datatype
codereport Aug 10, 2020
9851a21
Merge branch 'branch-0.15' into fp-scale-to-datatype
codereport Aug 18, 2020
b02a7d6
Merge branch 'test-fixed-point-iterator' of https://github.com/trevor…
codereport Aug 19, 2020
b993335
Merge branch 'test-fixed-point-iterator' into fp-scale-to-datatype
codereport Aug 19, 2020
9fae98b
Merge branch 'branch-0.15' into fp-scale-to-datatype
codereport Aug 24, 2020
277eec6
Fix mockup of ColumnLike, get unit tests working, clang-format
codereport Aug 24, 2020
d4040f4
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Aug 24, 2020
1b48159
Update CHANGELOG
codereport Aug 24, 2020
960bd17
Fix formatting
codereport Aug 24, 2020
9bb8390
Add scale_type ctor to data_type
codereport Aug 25, 2020
44cc072
Formatting of make_fixed_width_column for readability
codereport Aug 25, 2020
baa0e1b
Fix typo
codereport Aug 26, 2020
229123a
Add `cudf::` to data_type member for consistency
codereport Aug 26, 2020
a6ca667
Update comment
codereport Aug 27, 2020
29d0314
Add `scale` method to data_type
codereport Aug 27, 2020
892ee5f
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Aug 31, 2020
d13f74c
Clean up column_view_printer for fixed_point
codereport Aug 31, 2020
dd51e3f
Add decimal32 specialization for .element()
codereport Aug 31, 2020
0e072b8
Add initial `fixed_point_column_wrapper`
codereport Aug 31, 2020
46a2258
Add temporary change to column_view_printer
codereport Aug 31, 2020
4053070
Add unit test for simple `fixed_point_column_wrapper`
codereport Aug 31, 2020
5c5be89
Add `thrust::optional` to `data_type::_scale`
codereport Aug 31, 2020
8ef0833
Make `fixed_point_column_wrapper` unit test for both reps
codereport Aug 31, 2020
070669c
Add decimal64 specialization for .element()
codereport Aug 31, 2020
90d8f4c
Update column_view_printer for decimal64
codereport Aug 31, 2020
5196c79
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Aug 31, 2020
3dfc0b8
Small cleanup
codereport Sep 2, 2020
3341265
Fix for failing unit tests
codereport Sep 2, 2020
cfefc9d
CUDF_EXPECTS data_type::_scale to be set
codereport Sep 2, 2020
aee7ea3
Add unit test for data_type::_scale not set
codereport Sep 2, 2020
b8d88cf
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 2, 2020
5c1b266
Remove TODO comment
codereport Sep 2, 2020
c88628b
data_type ctor docs and CUDF_EXPECTS
codereport Sep 2, 2020
053cc0a
Add unit test for wrong type_id in data_type ctor
codereport Sep 2, 2020
af453b2
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 3, 2020
2ab702e
Remove `thrust::optional` from scale in data_type
codereport Sep 3, 2020
4abdd26
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 4, 2020
b1cb93c
Update CHANGELOG
codereport Sep 5, 2020
b6c1b03
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 8, 2020
8d071e2
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 9, 2020
6c97062
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 10, 2020
a6b76c3
IIFE clean up
codereport Sep 11, 2020
b61c531
Return fixed_point without temporary scaled_integer
codereport Sep 22, 2020
894db88
Change fixed_point unit test to 0 scale
codereport Sep 22, 2020
1adbec9
Add cudf::distance to avoid implicit casting
codereport Sep 25, 2020
d70d6f7
Temporary fix for FILLING_TEST
codereport Sep 25, 2020
c56c3a0
Add fixed_point specialization for make_elements
codereport Sep 25, 2020
0e02133
Fixed FIXED_POINT_TEST
codereport Sep 25, 2020
a7e096f
Cleanup unit test
codereport Sep 25, 2020
b1f34d8
Add specialization of cudf::to_host for fixed_point
codereport Sep 25, 2020
c071fc5
Add another specialization of make_elements
codereport Sep 25, 2020
4616853
Use .empty() instead of == 0
codereport Sep 25, 2020
5a15104
Fix ROLLING_TEST
codereport Sep 26, 2020
9a13524
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 26, 2020
c3edfd8
CI fix
codereport Sep 26, 2020
dc056da
Fix CI: get_current_default_resource
codereport Sep 26, 2020
21fa285
Delete file
codereport Sep 26, 2020
3f63b64
Merge mistake: host_vector should be of RepType
codereport Sep 26, 2020
ff84ba3
Use counting iterator + transform iterator
codereport Sep 26, 2020
33eda4b
Use lambda and transform iterator
codereport Sep 26, 2020
b675232
Add const
codereport Sep 26, 2020
82dff7a
Cleanup
codereport Sep 26, 2020
ae33500
Fix (can't use generic lambda)
codereport Sep 27, 2020
aadd001
Use std::for_each & std::any_of
codereport Sep 28, 2020
a31302f
Fixed `RESHAPE_TEST` & `TRANSPOSE_TEST`
codereport Sep 28, 2020
4a322d3
Fix PARTITIONING_TEST and some of COPYING_TEST
codereport Sep 28, 2020
936736f
Fix ShiftTests of COPYING_TEST
codereport Sep 28, 2020
baf3800
Cleanup: use ternary opreator
codereport Sep 28, 2020
60b0189
Fix MERGE_TEST
codereport Sep 28, 2020
7cd9589
Temporarily disable BINOP
codereport Sep 28, 2020
7ec7bf9
Fix for ScatterScalar tests of COPYING_TEST
codereport Sep 28, 2020
4e100cd
Fix DictionaryConcat tests of COPYING_TEST
codereport Sep 28, 2020
e37748e
Disable copy_range for fixed_point
codereport Sep 28, 2020
4829956
Add specialization for copy_range fixed_point
codereport Sep 28, 2020
88a75a9
Temporarily disable REPLACE_TEST for fixed_point
codereport Sep 28, 2020
84a95ce
Use snake_case cleanup
codereport Sep 28, 2020
d5af24a
Add back REPLACE_TEST for fixed_point
codereport Sep 28, 2020
4550898
Use cudf::test::make_counting_transform_iterator
codereport Sep 28, 2020
20ed4c1
Fix for REPLACE_TEST
codereport Sep 28, 2020
b3f4561
Add get_column_stored_type
codereport Sep 29, 2020
153286b
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 29, 2020
0ce98b2
Add CUDF_EXPECTS on representation type
codereport Sep 30, 2020
5eccfbd
Fix/cleanup cudf::to_host for fixed_point
codereport Sep 30, 2020
da18218
Add simple fixed_point_column_wrapper test
codereport Sep 30, 2020
e9da252
fixed_point column_view_printer
codereport Sep 30, 2020
3fc3d23
Small cleanup
codereport Sep 30, 2020
54f3694
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Sep 30, 2020
f636ae9
Remove [&]
codereport Sep 30, 2020
b6453fc
Remove 10 * (from trying to break tests)
codereport Sep 30, 2020
36b7b2f
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Oct 1, 2020
d844586
Rename _scale and adjust comment for clarity
codereport Oct 1, 2020
43cd630
Add column_type_id_matches_column_stored_type
codereport Oct 2, 2020
9e57aaf
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Oct 2, 2020
94046a7
Use thrust::copy_if with stencil
codereport Oct 2, 2020
7b07386
Add missing header
codereport Oct 2, 2020
bc3e4c3
Docs and removing TODOs
codereport Oct 2, 2020
e1ab9ae
Disable binop ptx with fixed_point
codereport Oct 3, 2020
7d17ba4
Add initial support for fixed_point binary operations
codereport Oct 3, 2020
104599a
Enable some of the binary op tests
codereport Oct 3, 2020
d3297c3
Refactor / cleanup
codereport Oct 3, 2020
326267d
Remove rmm_log.txt
codereport Oct 3, 2020
7c6c566
Remove unnecessary header
codereport Oct 3, 2020
4dd9c0c
Use .is_empty() instead of .size() == 0
codereport Oct 4, 2020
af89f8e
Make changes to fixed_point_scalar
codereport Oct 5, 2020
6304448
Changes to search.cu
codereport Oct 5, 2020
5c5968f
Changes to scalar_construction_helper
codereport Oct 5, 2020
4eeeba9
Changes to null.cu
codereport Oct 5, 2020
febec6b
Changes to src/dictionary/search.cu
codereport Oct 5, 2020
7c695fe
Changes to fixed_point_scalar
codereport Oct 5, 2020
b15f30a
Remove temporary changes
codereport Oct 6, 2020
6ad58b2
Addressing PR comments
codereport Oct 6, 2020
b4aa4a4
Update cpp/include/cudf/utilities/type_dispatcher.hpp
codereport Oct 6, 2020
bb0edb4
Update cpp/include/cudf/column/column_factories.hpp
codereport Oct 6, 2020
0e705f1
Update cpp/include/cudf/column/column_factories.hpp
codereport Oct 6, 2020
8458386
Update cpp/include/cudf/utilities/type_dispatcher.hpp
codereport Oct 6, 2020
762e8cf
Fix formatting
codereport Oct 6, 2020
756a2e9
Changes from PR 6063 and 6064
codereport Oct 6, 2020
f1f75b5
Addressing PR comments
codereport Oct 6, 2020
c52c05c
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Oct 6, 2020
debccea
CI Fix
codereport Oct 6, 2020
3934bb4
Update cpp/src/merge/merge.cu
codereport Oct 6, 2020
56fcb8f
Update cpp/src/merge/merge.cu
codereport Oct 6, 2020
3983338
Update cpp/src/merge/merge.cu
codereport Oct 6, 2020
0c21659
Update cpp/src/merge/merge.cu
codereport Oct 6, 2020
31a997a
Update cpp/src/merge/merge.cu
codereport Oct 6, 2020
28795d4
Update cpp/src/merge/merge.cu
codereport Oct 6, 2020
b60a840
Auto commit fix
codereport Oct 6, 2020
7a9dd92
Replace for_each with all_of
codereport Oct 6, 2020
38257b1
Cleanup in types.hpp
codereport Oct 6, 2020
29b8d65
Changes for fixed_point binary operations
codereport Oct 6, 2020
284843c
fixed_point binop different scales
codereport Oct 6, 2020
a115839
Enable last binop fixed_point test
codereport Oct 6, 2020
3db0d14
Clean up tests (remove TODO) and support both decimal32/64
codereport Oct 6, 2020
8e65898
Final binop cases for fixed_point
codereport Oct 6, 2020
13957f7
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Oct 6, 2020
7688a74
Addressing PR comments
codereport Oct 7, 2020
5976bb3
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Oct 7, 2020
c08286c
fixed_point_scalar_device_view inheritance from scalar_device_*
codereport Oct 7, 2020
1b3289a
Testing CI
codereport Oct 7, 2020
6842e96
Final TODOs (docs)
codereport Oct 7, 2020
ff5e919
Remove redundant is_fixed_point
codereport Oct 7, 2020
6891c9f
Fix for AST (thank you David)
codereport Oct 8, 2020
08d84ee
Remove headers + clean up
codereport Oct 8, 2020
7a844b1
Remove headers
codereport Oct 8, 2020
cf5d39a
fixed_point scalar factory test
codereport Oct 9, 2020
a0caa62
scalar_test for fixed_point
codereport Oct 9, 2020
49e84d0
Rename fn to type_id_matched_device_storage_type
codereport Oct 9, 2020
12cc8ab
Remove header
codereport Oct 9, 2020
30eb65a
Addressing PR comments, fixed_point_column_wrapper tests
codereport Oct 9, 2020
364e52e
Revert type_id_matches... changes
codereport Oct 9, 2020
eacdf62
Simplify device_storage_type_t docs
codereport Oct 10, 2020
4c0f113
Add failing binop test
codereport Oct 13, 2020
124e388
Disable `fixed_point` binaryops
codereport Oct 13, 2020
8ed8d17
Merge branch 'branch-0.16' into fp-scale-to-datatype
codereport Oct 13, 2020
047b888
Addressing PR comments
codereport Oct 13, 2020
9031bd4
Spelling fixes
codereport Oct 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
factories_test.cpp remove FixedWidthTypesWithoutFixedPoint
codereport committed Aug 6, 2020
commit 6e2bf322fd3f22a5402e09c3b7c46d3e68f39d34
2 changes: 1 addition & 1 deletion cpp/tests/column/factories_test.cpp
Original file line number Diff line number Diff line change
@@ -199,7 +199,7 @@ template <typename T>
class FixedWidthFactoryTest : public ColumnFactoryTest {
};

TYPED_TEST_CASE(FixedWidthFactoryTest, cudf::test::FixedWidthTypesWithoutFixedPoint);
TYPED_TEST_CASE(FixedWidthFactoryTest, cudf::test::FixedWidthTypes);

TYPED_TEST(FixedWidthFactoryTest, EmptyNoMask)
{