Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add duration types support in cudf(python/cython) #5781

Merged
merged 121 commits into from
Aug 13, 2020

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jul 28, 2020

  • Add support for TimedeltaColumn
  • Add support for TimedeltaIndex
  • Enable all-way type-cast conversions for TimedeltaColumn(as_string_column pending as it is dependent on [REVIEW] string conversion for duration types (to_durations, from_durations) #5625)
  • Enable support timedelta64[s], timedelta64[ms], timedelta64[us], timedelta64[ns] dtypes in cudf.
  • Enable Scalar constructor to take valid boolean flag to be able to manually set the mask.
  • Ability to perform add & subtract binop between TimeDeltaColumn and DatetimeColumn.
  • Ability to perform subtract binop between DatetimeColumn and DatetimeColumn.
  • Fix issue in DatetimeColumn.binary_operator where reflect was being ignored and radd, rsub would fail.
  • Add valid_scalar param in **kwargs to Column.default_na_value for the purpose of requesting a valid Scalar object of NaT incase of TimeDeltaColumn and DatetimeColumn.
  • Add support for reduction ops in TimeDeltaColumn.
  • Add support for __array_ufunc__ in Index objects.
  • Add cudf.subtract, cudf.add, cudf.true_divide, cudf.multiply methods to support __array_ufunc__.
  • Fixes [BUG] TypeError when adding numpy integer to cudf Series #5777 (above additions will also fix this issue).
  • Add support for TimedeltaProperties which can be accessed by dt accessor of Series, example: Series.dt
  • Avoid broadcasting scalars and creating a column of equal length in normalize_binop_value, as we have binop_v_s implemented to care of such cases.
  • Add TimedeltaIndex to docs/api.rst
  • Resolves [ENH] Add .from_arrow constructors for cuDF column types #5697

@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. Cython labels Jul 28, 2020
@galipremsagar galipremsagar self-assigned this Jul 28, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python / Cython LGTM

Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on libcudf side

@kkraus14 kkraus14 added 4 - Needs Review Waiting for reviewer to review or respond libcudf Affects libcudf (C++/CUDA) code. and removed 4 - Needs cuDF (Python) Reviewer labels Aug 11, 2020
Copy link
Contributor

@sriramch sriramch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other cpp changes lgtm.

Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for C++ changes.

@galipremsagar
Copy link
Contributor Author

rerun tests

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Aug 12, 2020
@kkraus14 kkraus14 merged commit 1d23876 into rapidsai:branch-0.15 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
8 participants