-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add duration types support in cudf(python/cython) #5781
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python / Cython LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on libcudf side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other cpp changes lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for C++ changes.
rerun tests |
TimedeltaColumn
TimedeltaIndex
TimedeltaColumn
(as_string_column
pending as it is dependent on [REVIEW] string conversion for duration types (to_durations, from_durations) #5625)timedelta64[s]
,timedelta64[ms]
,timedelta64[us]
,timedelta64[ns]
dtypes in cudf.Scalar
constructor to takevalid
boolean flag to be able to manually set the mask.add
&subtract
binop betweenTimeDeltaColumn
andDatetimeColumn
.subtract
binop betweenDatetimeColumn
andDatetimeColumn
.DatetimeColumn.binary_operator
wherereflect
was being ignored andradd
,rsub
would fail.valid_scalar
param in**kwargs
toColumn.default_na_value
for the purpose of requesting a validScalar
object ofNaT
incase ofTimeDeltaColumn
andDatetimeColumn
.TimeDeltaColumn
.__array_ufunc__
inIndex
objects.cudf.subtract
,cudf.add
,cudf.true_divide
,cudf.multiply
methods to support__array_ufunc__
.TimedeltaProperties
which can be accessed bydt
accessor of Series, example:Series.dt
normalize_binop_value
, as we havebinop_v_s
implemented to care of such cases.TimedeltaIndex
todocs/api.rst
.from_arrow
constructors for cuDF column types #5697