Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add cudf::lists::extract_list_element API #5753

Merged
merged 21 commits into from
Aug 3, 2020

Conversation

davidwendt
Copy link
Contributor

Closes #5742

New API to extract elements from a lists column into a new column

std::unique_ptr<column> extract_list_element(
  lists_column_view const& lists_column,
  size_type index,
  rmm::mr::device_memory_resource* mr);

The index is used to extract individual elements from each of the lists components to build a new column as described in #5742

@davidwendt davidwendt self-assigned this Jul 23, 2020
@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. labels Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #5753 into branch-0.15 will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #5753      +/-   ##
===============================================
+ Coverage        84.06%   84.40%   +0.33%     
===============================================
  Files               80       80              
  Lines            13066    13381     +315     
===============================================
+ Hits             10984    11294     +310     
- Misses            2082     2087       +5     
Impacted Files Coverage Δ
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/custreamz/custreamz/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 98.75% <0.00%> (+0.02%) ⬆️
python/cudf/cudf/core/join/join.py 92.41% <0.00%> (+0.03%) ⬆️
...ython/custreamz/custreamz/tests/test_dataframes.py 98.80% <0.00%> (+0.03%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8f993...8616878. Read the comment docs.

@davidwendt davidwendt changed the title [WIP] Add cudf::lists::extract_list_element API [REVIEW] Add cudf::lists::extract_list_element API Jul 28, 2020
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 28, 2020
@davidwendt davidwendt marked this pull request as ready for review July 28, 2020 15:09
@davidwendt davidwendt requested review from a team as code owners July 28, 2020 15:09
@davidwendt davidwendt requested review from cwharris and vuule July 28, 2020 15:09
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake lgtm

Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor suggestion

cpp/src/lists/extract.cu Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added the 4 - Needs Review Waiting for reviewer to review or respond label Jul 29, 2020
cpp/include/cudf/lists/extract.hpp Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

rerun tests

@davidwendt davidwendt merged commit d269895 into rapidsai:branch-0.15 Aug 3, 2020
@davidwendt davidwendt deleted the fea-extract-from-list branch August 3, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] extract item from a list by index
5 participants