[REVIEW] [CUIO] Replace owning raw pointers with std::unique_ptr #5720
Conversation
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
vuule
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #5720 +/- ##
==============================================
Coverage ? 86.38%
==============================================
Files ? 76
Lines ? 13041
Branches ? 0
==============================================
Hits ? 11265
Misses ? 1776
Partials ? 0 Continue to review full report at Codecov.
|
vuule
changed the title
cpp/src/io/comp/uncomp.cpp
Outdated
| } | ||
| return decompressor; | ||
| return {}; |
There was a problem hiding this comment.
Should you throw / CUDF_FAIL here?
There was a problem hiding this comment.
This keeps the original behavior - return null if the compression type is not supported.
I'll check if null is actually signalling an error here.
There was a problem hiding this comment.
Yup, returning null here causes an error later on, when trying to parse the data that was never successfully read. Added CUDF_FAIL, removed code that assumes that the decompressor can be null.
…emove-cuio-new-calls
…into remove-cuio-new-calls
HostDecompressor::Createused to return a raw pointer to a newly created object. Because of this, the caller had a destructor.With this PR, a
unique_ptris returned instead, and the caller's destructor is removed.