Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add a double type dispatcher. #5716

Merged
merged 13 commits into from
Jul 30, 2020
Merged

[REVIEW] Add a double type dispatcher. #5716

merged 13 commits into from
Jul 30, 2020

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 17, 2020

This PR adds a double type dispatcher, for use in the AST (#5493, #5494).

@bdice bdice added the 2 - In Progress Currently a work in progress label Jul 17, 2020
@bdice bdice self-assigned this Jul 17, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

1 similar comment
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

jrhemstad
jrhemstad requested changes Jul 17, 2020
View reviewed changes
cpp/include/cudf/utilities/type_dispatcher.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/utilities/type_dispatcher.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/utilities/type_dispatcher.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/utilities/type_dispatcher.hpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 18, 2020 •
edited
Loading

Codecov Report

Merging #5716 into branch-0.15 will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #5716      +/-   ##
===============================================
+ Coverage        86.14%   86.43%   +0.29%     
===============================================
  Files               75       75              
  Lines            12715    13031     +316     
===============================================
+ Hits             10953    11263     +310     
- Misses            1762     1768       +6
Impacted Files Coverage Δ
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 98.75% <0.00%> (+0.02%) ⬆️
python/cudf/cudf/core/join/join.py 92.41% <0.00%> (+0.03%) ⬆️
...ython/custreamz/custreamz/tests/test_dataframes.py 98.80% <0.00%> (+0.03%) ⬆️
python/cudf/cudf/core/frame.py 89.76% <0.00%> (+0.04%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a3ac6...c1065dc. Read the comment docs.

@bdice bdice changed the title [WIP] Add a double type dispatcher. Add a double type dispatcher. Jul 18, 2020
@bdice bdice requested a review from jrhemstad July 18, 2020 03:43
@bdice bdice marked this pull request as ready for review July 18, 2020 03:43
@bdice bdice requested a review from a team as a code owner July 18, 2020 03:43
@bdice bdice requested a review from devavret July 18, 2020 03:43
@bdice bdice added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 18, 2020
@harrism harrism changed the title Add a double type dispatcher. [REVIEW] Add a double type dispatcher. Jul 19, 2020
@bdice bdice added 4 - Needs Review Waiting for reviewer to review or respond libcudf Affects libcudf (C++/CUDA) code. labels Jul 24, 2020
@bdice bdice mentioned this pull request Jul 26, 2020
Merged
8 tasks
@bdice bdice requested a review from jrhemstad July 26, 2020 21:32
harrism
harrism approved these changes Jul 26, 2020
View reviewed changes
cpp/tests/types/type_dispatcher_test.cu Outdated Show resolved Hide resolved
@jrhemstad jrhemstad merged commit 9e5196d into rapidsai:branch-0.15 Jul 30, 2020
@bdice bdice deleted the double-dispatcher branch July 30, 2020 15:52
@bdice bdice mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@devavret devavret Awaiting requested review from devavret

Assignees

@bdice bdice

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @GPUtester @harrism @jrhemstad