-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add filter_tokens nvtext API #5658
[REVIEW] Add filter_tokens nvtext API #5658
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #5658 +/- ##
===============================================
- Coverage 86.21% 85.94% -0.28%
===============================================
Files 72 72
Lines 12727 12439 -288
===============================================
- Hits 10973 10691 -282
+ Misses 1754 1748 -6
Continue to review full report at Codecov.
|
filter_tokens
nvtext APIThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python / Cython looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Good use of 🔥 in the unit tests 😄. Just a minor suggestion to try empty_like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor questions/suggestions, the PR looks great overall!
Closes #5521
Add function to filter tokens from strings based on the length of each token as described in #5521
This PR also includes the Python strings API and the required Cython interfaces.