Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] switch from CNMeM to pool_memory_resource [skip ci] #5632

Merged
merged 4 commits into from
Jul 10, 2020
Merged

[REVIEW] switch from CNMeM to pool_memory_resource [skip ci] #5632

merged 4 commits into from
Jul 10, 2020

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Jul 3, 2020

@rongou rongou requested a review from a team as a code owner July 3, 2020 00:53
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

harrism
harrism reviewed Jul 5, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jlowe
jlowe requested changes Jul 6, 2020
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java/README.md needs to be updated. It refers to dynamically linking against librmm which is no longer the case after this change. It also has instructions for rebuilding RMM for static linking and/or for per-thread default stream.

@jlowe jlowe added the Java Affects Java cuDF API. label Jul 6, 2020
@rongou
Copy link
Contributor Author

rongou commented Jul 6, 2020

java/README.md needs to be updated. It refers to dynamically linking against librmm which is no longer the case after this change. It also has instructions for rebuilding RMM for static linking and/or for per-thread default stream.

Done.

@rongou rongou requested review from jlowe and harrism July 6, 2020 16:34
@jlowe jlowe mentioned this pull request Jul 9, 2020
Merged
@rongou rongou mentioned this pull request Jul 10, 2020
Closed
@revans2 revans2 merged commit 71ef47c into rapidsai:branch-0.15 Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@jlowe jlowe jlowe approved these changes

@harrism harrism Awaiting requested review from harrism

Assignees
No one assigned
Labels
Java Affects Java cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rongou @GPUtester @harrism @jlowe @revans2