Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add MD5 to existing hashing functionality #5438
[REVIEW] Add MD5 to existing hashing functionality #5438
Changes from 17 commits
b626432
0d3845c
d32552d
a5ed47f
f4ad66e
fa8c5d1
535ff93
c1725ec
14d7672
fa93274
94ceeae
8ae065e
efd8fdb
ba9efae
f3daf4b
f41c8cc
614182b
6aaa7b8
3b68a9d
7379b23
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the same function exposed two ways. Either the Python should be updated to call the
hash
with theHASH_MURMUR3
enum or get rid of thehash
API and add a specific MD5 hash. I'd opt for the former.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mirrored the
hash_id
enum over to the python side and removed the murmur hash specific function.