Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Exposing stream arguments for joins #5428

Closed
wants to merge 3 commits into from
Closed

[REVIEW] Exposing stream arguments for joins #5428

wants to merge 3 commits into from

Conversation

magnatelee
Copy link
Contributor

@magnatelee magnatelee commented Jun 9, 2020 •
edited
Loading

This PR is to add stream arguments to the join calls, partially addressing #925.

@magnatelee magnatelee requested a review from a team as a code owner June 9, 2020 04:16
@magnatelee magnatelee requested review from trxcllnt and nvdbaranec June 9, 2020 04:16
harrism
harrism requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't decided yet how we will expose asynchrony in the libcudf public API, which is why #925 is still open.

@magnatelee magnatelee closed this Jun 9, 2020
@magnatelee magnatelee reopened this Jun 9, 2020
@magnatelee magnatelee closed this Jun 9, 2020
@magnatelee magnatelee deleted the stream-arg-for-join branch June 14, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism requested changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnatelee @harrism