[REVIEW] Fix groupby apply for operations that fail on empty groups #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
approved these changes
Apr 3, 2020
kkraus14
added
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-0.14 #4796 +/- ##
===============================================
- Coverage 88.42% 88.42% -0.01%
===============================================
Files 51 51
Lines 9738 9736 -2
===============================================
- Hits 8611 8609 -2
Misses 1127 1127
Continue to review full report at Codecov.
|
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for groupby.apply() adds an extraneous "empty" group, which would result in operations that don't work for empty dataframes fail.