Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add cudf._cuda to setup.py #4793

Merged
merged 3 commits into from
Apr 3, 2020
Merged

[REVIEW] Add cudf._cuda to setup.py #4793

merged 3 commits into from
Apr 3, 2020

Conversation

galipremsagar
Copy link
Contributor

Fixes: #4785

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Apr 3, 2020
@galipremsagar galipremsagar requested a review from kkraus14 April 3, 2020 14:46
@galipremsagar galipremsagar requested a review from a team as a code owner April 3, 2020 14:46
@galipremsagar galipremsagar self-assigned this Apr 3, 2020
@galipremsagar galipremsagar changed the title [REVIEW] Add cuda._cuda to setup.py [REVIEW] Add cudf._cuda to setup.py Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #4793 into branch-0.14 will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.14    #4793   +/-   ##
============================================
  Coverage        88.42%   88.42%           
============================================
  Files               51       51           
  Lines             9738     9738           
============================================
  Hits              8611     8611           
  Misses            1127     1127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 627ebc5...a863fff. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Apr 3, 2020

While we're at it, it's maybe a good idea to add cudf/_cuda/*.cpp to .gitignore as I noticed I had to ignore it locally. :)

@galipremsagar
Copy link
Contributor Author

While we're at it, it's maybe a good idea to add cudf/_cuda/*.cpp to .gitignore as I noticed I had to ignore it locally. :)

Thanks @shwina, added it 👍

kkraus14
kkraus14 reviewed Apr 3, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@galipremsagar @kkraus14
Update .gitignore
a863fff 
Co-Authored-By: Keith Kraus <[email protected]>
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Apr 3, 2020
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@kkraus14 kkraus14 merged commit f5b7ed6 into rapidsai:branch-0.14 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Modify setup.py to ship _cuda pxd files
4 participants
@galipremsagar @shwina @GPUtester @kkraus14