Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add GPU and CUDA validations #4692
[REVIEW] Add GPU and CUDA validations #4692
Changes from 11 commits
5961872
e92c6b5
91baa1c
9617fb9
0709532
a61ab8e
d1f1717
44de100
bc55a75
2be6ea3
8d1482b
2e05d96
e4c3288
fe75c23
7272afc
04826a1
0d9c6bb
e6add1e
7c8cb5b
6818152
6ac3a93
5171b0e
7d6dcc8
79854f4
0643e71
3a7ab8c
012a6de
6032e64
b0bb113
8f8fd5c
2e23210
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warn about what CUDA version was detected as opposed to just saying to update to 10.0 or above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to also print
cuda_runtime_version
in the error message? Or parsecuda_runtime_version
to print the cuda version in error message?Asking this because
cuda_runtime_version
needs int to str conversion like..CUDA 10.0 - cuda_runtime_version: 10000
CUDA 10.10 - cuda_runtime_version: 10010
CUDA 10.20 - cuda_runtime_version: 10020
In the docs I couldn't find the minor version is always going to be a double-digit number, else it would be a straight forward string split.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should parse it from these numbers and present it cleanly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, now the detected CUDA version will be printed.