Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix Slicing issue with categorical column in DataFrame #4683

Merged

Conversation

rgsl888prabhu
Copy link
Contributor

call to codes materializes the column and gets a new column without any offset which resulted in the issue #4678

closes #4678

@rgsl888prabhu rgsl888prabhu added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Mar 25, 2020
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner March 25, 2020 03:30
@rgsl888prabhu rgsl888prabhu self-assigned this Mar 25, 2020
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #4683 into branch-0.13 will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.13    #4683      +/-   ##
===============================================
- Coverage        88.43%   88.42%   -0.01%     
===============================================
  Files               50       50              
  Lines             9676     9696      +20     
===============================================
+ Hits              8557     8574      +17     
- Misses            1119     1122       +3     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 89.12% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 93.67% <100.00%> (+0.12%) ⬆️
python/cudf/cudf/core/column/column.py 87.28% <100.00%> (-0.11%) ⬇️
python/cudf/cudf/core/frame.py 89.32% <100.00%> (+0.03%) ⬆️
python/cudf/cudf/core/reshape.py 86.50% <100.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/backends.py 97.14% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 92.98% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a4899...4ee660b. Read the comment docs.

python/cudf/cudf/_libxx/column.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/column.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/column.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/column.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/categorical.py Outdated Show resolved Hide resolved
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner March 26, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Slicing a DataFrame with categoricals gives incorrect results
5 participants