-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix Slicing issue with categorical column in DataFrame #4683
Merged
raydouglass
merged 14 commits into
rapidsai:branch-0.13
from
rgsl888prabhu:4678_dataframe_slice_copy_issur
Mar 26, 2020
Merged
[REVIEW] Fix Slicing issue with categorical column in DataFrame #4683
raydouglass
merged 14 commits into
rapidsai:branch-0.13
from
rgsl888prabhu:4678_dataframe_slice_copy_issur
Mar 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgsl888prabhu
added
3 - Ready for Review
Ready for review by team
Python
Affects Python cuDF API.
4 - Needs cuDF (Python) Reviewer
labels
Mar 25, 2020
Codecov Report
@@ Coverage Diff @@
## branch-0.13 #4683 +/- ##
===============================================
- Coverage 88.43% 88.42% -0.01%
===============================================
Files 50 50
Lines 9676 9696 +20
===============================================
+ Hits 8557 8574 +17
- Misses 1119 1122 +3
Continue to review full report at Codecov.
|
…rgsl888prabhu/cudf into 4678_dataframe_slice_copy_issur
kkraus14
requested changes
Mar 25, 2020
kkraus14
requested changes
Mar 26, 2020
… to only codes not to child
kkraus14
reviewed
Mar 26, 2020
kkraus14
reviewed
Mar 26, 2020
kkraus14
requested changes
Mar 26, 2020
kkraus14
approved these changes
Mar 26, 2020
galipremsagar
approved these changes
Mar 26, 2020
vyasr
added
4 - Needs Review
Waiting for reviewer to review or respond
and removed
4 - Needs cuDF (Python) Reviewer
labels
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
4 - Needs Review
Waiting for reviewer to review or respond
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call to codes materializes the column and gets a new column without any offset which resulted in the issue #4678
closes #4678