Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enabling .str.find_multiple with new libcudf implementation #4575

Closed

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 18, 2020

Resolves: #4569

Having a discussion internally on the output format - hence marking draft for now.

@galipremsagar
Copy link
Contributor Author

After an internal discussion, we decided to go ahead with using cython API directly and will probably plumb this API once there is list columns support in future releases. Closing this PR for the future release.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #4575 into branch-0.13 will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.13    #4575      +/-   ##
===============================================
- Coverage         88.5%   88.49%   -0.02%     
===============================================
  Files               50       50              
  Lines             9625     9629       +4     
===============================================
+ Hits              8519     8521       +2     
- Misses            1106     1108       +2
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 86.51% <50%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24632d3...0254429. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Python find_multiple still expects an nvstrings object as a parameter
1 participant