Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable compile-errors on deprecation warnings, for JNI [skip ci] #4557

Merged

Conversation

mythrocks
Copy link
Contributor

Disabled compilation failures on JNI native code, for deprecation warnings.
E.g.

../src/strings/utilities.cuh:82:48:   required from ‘auto cudf::strings::detail::make_strings_children(SizeAndExecuteFunction, cudf::size_type, cudf::size_type, rmm::mr::device_memory_resource*, cudaStream_t) [with SizeAndExecuteFunction = cudf::strings::detail::_GLOBAL__N__56_tmpxft_00006cba_00000000_8_backref_re_compute_75_cpp1_ii_c02a6011::backrefs_fn<112>; cudf::size_type = int; cudaStream_t = CUstream_st*]’
../src/strings/replace/backref_re.cu:205:173:   required from here
/home/mithunr/workspace/anaconda2/envs/cudf_dev/include/rmm/thrust_rmm_allocator.h:61:10: warning: ‘rmmError_t rmm::free(void*, cudaStream_t, const char*, unsigned int)’ is deprecated [-Wdeprecated-declarations]
       RMM_FREE(thrust::raw_pointer_cast(ptr), stream);
       ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mithunr/workspace/anaconda2/envs/cudf_dev/include/rmm/rmm.hpp:192:34: note: declared here

@mythrocks mythrocks requested a review from a team as a code owner March 17, 2020 23:52
@jlowe jlowe changed the title Disable compile-errors on deprecation warnings, for JNI Disable compile-errors on deprecation warnings, for JNI [skip ci] Mar 17, 2020
@jlowe jlowe added the Java Affects Java cuDF API. label Mar 17, 2020
@jlowe
Copy link
Member

jlowe commented Mar 17, 2020

@kkraus14 @harrism this should be ready to merge into branch-0.13 to fix the JNI build. Thanks!

@kkraus14 kkraus14 merged commit 3482431 into rapidsai:branch-0.13 Mar 18, 2020
@mythrocks mythrocks deleted the deprecation-error-disable-branch-0.13 branch March 18, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Affects Java cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants