-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Remove string_view is_null method #4548
[REVIEW] Remove string_view is_null method #4548
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.14 #4548 +/- ##
===============================================
- Coverage 88.42% 88.42% -0.01%
===============================================
Files 50 50
Lines 9686 9681 -5
===============================================
- Hits 8565 8560 -5
Misses 1121 1121
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, other than. LGTM
Closes #3346
The
string_view
class has three states: non-empty, empty, and null.The null-state should not be required since we have a
string_scalar
class now.Places where the
string_view:is_null()
function are being used can be reworked.These were only found in
strings::fill()
,strings::concatenate()
andstrings:join_strings()
which all acceptstring_scalar
parameters.Removing this method also means that
string_view
has only 2 states now: empty or non-empty. This should solve the requirement of all-empty strings column requiring a 1-byte chars column. This column was needed to distinguish between null and empty when creating astring_view
in methods likestring_scalar::value()
andcolumn_device_view::element<string_view>()
. Since this is no longer possible, special logic is not required for handling a nullstring_view
instance.Therefore, any workaround logic in
string.py
andstrings/utilities.cu
to preserve the 1-byte chars column for all-empty strings column is no longer required.