Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Check for multi-dimensional data in column/Series creation #4506

Merged
merged 18 commits into from
Mar 17, 2020
Merged

[REVIEW] Check for multi-dimensional data in column/Series creation #4506

merged 18 commits into from
Mar 17, 2020

Conversation

galipremsagar
Copy link
Contributor

Fixes: #4443

@galipremsagar galipremsagar requested a review from a team as a code owner March 13, 2020 22:15
@galipremsagar galipremsagar changed the title [REVIEW] Check for 1-d data for column/Series creation [REVIEW] Check for multi-dimensional data in column/Series creation Mar 13, 2020
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer Python Affects Python cuDF API. labels Mar 13, 2020
@codecov
Copy link

codecov bot commented Mar 13, 2020 •
edited
Loading

Codecov Report

Merging #4506 into branch-0.13 will increase coverage by 0.02%.
The diff coverage is 97.36%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.13    #4506      +/-   ##
===============================================
+ Coverage        88.68%   88.70%   +0.02%     
===============================================
  Files               50       50              
  Lines             9800     9804       +4     
===============================================
+ Hits              8691     8697       +6     
+ Misses            1109     1107       -2
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 89.11% <66.66%> (ø)
python/cudf/cudf/core/column/column.py 88.11% <100.00%> (+0.25%) ⬆️
python/cudf/cudf/core/column/datetime.py 87.50% <100.00%> (-0.10%) ⬇️
python/cudf/cudf/utils/utils.py 84.97% <100.00%> (+0.48%) ⬆️
python/dask_cudf/dask_cudf/backends.py 97.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9070740...ba27ff3. Read the comment docs.

kkraus14
kkraus14 requested changes Mar 14, 2020
View reviewed changes
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added 0 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 14, 2020
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 0 - Waiting on Author Waiting for author to respond to review labels Mar 15, 2020
kkraus14
kkraus14 requested changes Mar 16, 2020
View reviewed changes
python/cudf/cudf/core/column/column.py Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added 0 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 16, 2020
@galipremsagar galipremsagar changed the title [REVIEW] Check for multi-dimensional data in column/Series creation [WIP] Check for multi-dimensional data in column/Series creation Mar 16, 2020
@galipremsagar galipremsagar added the 2 - In Progress Currently a work in progress label Mar 16, 2020
@galipremsagar galipremsagar changed the title [WIP] Check for multi-dimensional data in column/Series creation [REVIEW] Check for multi-dimensional data in column/Series creation Mar 16, 2020
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress 0 - Waiting on Author Waiting for author to respond to review labels Mar 16, 2020
@galipremsagar galipremsagar changed the title [REVIEW] Check for multi-dimensional data in column/Series creation [WIP] Check for multi-dimensional data in column/Series creation Mar 16, 2020
@galipremsagar galipremsagar changed the title [WIP] Check for multi-dimensional data in column/Series creation [REVIEW] Check for multi-dimensional data in column/Series creation Mar 16, 2020
@galipremsagar galipremsagar changed the title [REVIEW] Check for multi-dimensional data in column/Series creation [WIP] Check for multi-dimensional data in column/Series creation Mar 17, 2020
@galipremsagar galipremsagar requested a review from a team as a code owner March 17, 2020 14:55
@galipremsagar galipremsagar changed the title [WIP] Check for multi-dimensional data in column/Series creation [REVIEW] Check for multi-dimensional data in column/Series creation Mar 17, 2020
kkraus14
kkraus14 requested changes Mar 17, 2020
View reviewed changes
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 17, 2020
@kkraus14 kkraus14 merged commit 7cd8c3a into rapidsai:branch-0.13 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Series should not accept multidimensional array inputs
2 participants
@galipremsagar @kkraus14