Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW][FEA] Port nvtx.pyx to use non-legacy libcudf APIs #4235

Merged
merged 45 commits into from
Mar 18, 2020

Conversation

millerhooks
Copy link
Contributor

@millerhooks millerhooks commented Feb 22, 2020

Added nvtx.pyx for libcudf++.

TODO:

  • Refactor existing uses of nvtx to use libcudf++

closes #3937

@millerhooks millerhooks requested a review from a team as a code owner February 22, 2020 05:55
@millerhooks millerhooks changed the title [FEA] Port nvtx.pyx to use non-legacy libcudf APIs [WIP][FEA] Port nvtx.pyx to use non-legacy libcudf APIs Feb 22, 2020
@millerhooks millerhooks self-assigned this Feb 22, 2020
@millerhooks millerhooks added 2 - In Progress Currently a work in progress libcudf++ feature request New feature or request labels Feb 22, 2020
@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #4235 into branch-0.13 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-0.13   #4235      +/-   ##
==============================================
+ Coverage        88.68%   88.7%   +0.01%     
==============================================
  Files               50      50              
  Lines             9800    9851      +51     
==============================================
+ Hits              8691    8738      +47     
- Misses            1109    1113       +4
Impacted Files Coverage Δ
python/cudf/cudf/core/column/datetime.py 87.5% <ø> (-0.1%) ⬇️
python/cudf/cudf/_libxx/__init__.py 100% <ø> (ø) ⬆️
python/cudf/cudf/core/dataframe.py 89.87% <100%> (+0.01%) ⬆️
python/cudf/cudf/core/column/string.py 86.72% <100%> (ø) ⬆️
python/cudf/cudf/core/series.py 91.42% <100%> (-0.01%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 96.24% <100%> (+0.01%) ⬆️
python/cudf/cudf/core/column/numerical.py 93.86% <100%> (-0.03%) ⬇️
python/dask_cudf/dask_cudf/core.py 72.42% <0%> (-2.58%) ⬇️
python/cudf/cudf/core/index.py 89.11% <0%> (ø) ⬆️
python/dask_cudf/dask_cudf/batcher_sortnet.py
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9070740...5e7b079. Read the comment docs.

python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
@millerhooks
Copy link
Contributor Author

I realize the if/else is hack. I was having issues getting a dictionary to work properly. Now that this works I'll see if I can't make the dict work.

@kkraus14
Copy link
Collaborator

kkraus14 commented Mar 5, 2020

I realize the if/else is hack. I was having issues getting a dictionary to work properly. Now that this works I'll see if I can't make the dict work.

Instead of using a dictionary use a Python Enum and use typecasting to the underlying_type similar to: https://github.com/rapidsai/cudf/blob/branch-0.13/python/cudf/cudf/_libxx/types.pyx

python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added the Python Affects Python cuDF API. label Mar 11, 2020
python/cudf/cudf/_libxx/cpp/nvtx.pxd Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/cpp/utilities/nvtx_utils.pxd Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/nvtx.pyx Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 0 - Waiting on Author Waiting for author to respond to review labels Mar 17, 2020
@kkraus14 kkraus14 merged commit 11903d2 into rapidsai:branch-0.13 Mar 18, 2020
mike-wendt added a commit that referenced this pull request Apr 1, 2020
These were mistakenly removed in #4235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Port nvtx.pyx to use non-legacy libcudf APIs
3 participants