-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW][FEA] Port nvtx.pyx to use non-legacy libcudf APIs #4235
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.13 #4235 +/- ##
==============================================
+ Coverage 88.68% 88.7% +0.01%
==============================================
Files 50 50
Lines 9800 9851 +51
==============================================
+ Hits 8691 8738 +47
- Misses 1109 1113 +4
Continue to review full report at Codecov.
|
I realize the if/else is hack. I was having issues getting a dictionary to work properly. Now that this works I'll see if I can't make the dict work. |
Instead of using a dictionary use a Python Enum and use typecasting to the underlying_type similar to: https://github.com/rapidsai/cudf/blob/branch-0.13/python/cudf/cudf/_libxx/types.pyx |
These were mistakenly removed in #4235
Added
nvtx.pyx
forlibcudf++
.TODO:
nvtx
to uselibcudf++
closes #3937