[REVIEW] adding Corr() function inside dataframe.py to compute the correlation matrix of a data frame and adding examples in series.py #4140

rnyak · 2020-02-12T22:03:32Z

No description provided.

python/cudf/cudf/tests/test_stats.py

Co-Authored-By: Keith Kraus <[email protected]>

codecov · 2020-02-13T20:14:29Z

Codecov Report

Merging #4140 into branch-0.13 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           branch-0.13   #4140      +/-   ##
==============================================
+ Coverage         88.8%   88.8%   +<.01%     
==============================================
  Files               50      50              
  Lines             9691    9696       +5     
==============================================
+ Hits              8606    8611       +5     
  Misses            1085    1085

Impacted Files	Coverage Δ
python/cudf/cudf/utils/ioutils.py	`86.3% <ø> (ø)`	⬆️
python/cudf/cudf/core/series.py	`91.65% <ø> (ø)`	⬆️
python/cudf/cudf/core/dataframe.py	`90.2% <100%> (+0.03%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a9344...5844786. Read the comment docs.

rnyak · 2020-02-19T21:20:04Z

@kkraus14 I have done the changes you requested for the unit tests. I also have just added an example in the ioutils.py for reading hex values as int. FYI.

python/cudf/cudf/utils/ioutils.py

kkraus14

One docstring issue then this looks good to go

CHANGELOG.md

python/cudf/cudf/utils/ioutils.py

Co-Authored-By: Keith Kraus <[email protected]>

kkraus14

LGTM, could probably use a review from @randerzander as I always fail at docstring formatting

randerzander

A small suggestion on hex to integer conversion in the read_csv docstring.

With that change and a confirmation from @rnyak that the Sphinx generated HTML files render correctly, this is good to go. Thanks for helping us improve our API docs!

python/cudf/cudf/utils/ioutils.py

randerzander · 2020-03-10T13:29:37Z

rerun tests

kkraus14 · 2020-03-10T21:37:20Z


+ python -c 'import cudf'

Traceback (most recent call last):

  File "<string>", line 1, in <module>

  File "/conda/conda-bld/cudf_1583851712040/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/cudf/__init__.py", line 4, in <module>

    from cudf import core, datasets

  File "/conda/conda-bld/cudf_1583851712040/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/cudf/core/__init__.py", line 2, in <module>

    from cudf.core import buffer, column

  File "/conda/conda-bld/cudf_1583851712040/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/cudf/core/column/__init__.py", line 1, in <module>

    from cudf.core.column.categorical import CategoricalColumn  # noqa: F401

  File "/conda/conda-bld/cudf_1583851712040/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/cudf/core/column/categorical.py", line 10, in <module>

    import cudf._lib as libcudf

  File "/conda/conda-bld/cudf_1583851712040/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/cudf/_lib/__init__.py", line 1, in <module>

    from . import (

  File "cudf/_lib/avro.pyx", line 18, in init cudf._lib.avro

  File "/conda/conda-bld/cudf_1583851712040/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/cudf/utils/ioutils.py", line 801, in <module>

    remote_data_sources=_docstring_remote_sources

KeyError: '"hex_col" '

rnyak · 2020-03-11T15:02:46Z

@kkraus14 @randerzander will take a look at that what's going on. If we want to merge other docs edits asap, I can take out 'hex_col` lines and then add again and create a new PR once I figure out why we get this error.

kkraus14 · 2020-03-11T15:09:39Z

@kkraus14 @randerzander will take a look at that what's going on. If we want to merge other docs edits asap, I can take out 'hex_col` lines and then add again and create a new PR once I figure out why we get this error.

Please do.

kkraus14 · 2020-03-11T18:50:56Z

rerun tests

rnyak added 2 commits February 12, 2020 14:55

Update dataframe.py

0b2216a

Update test_stats.py

c91519c

rnyak requested a review from a team as a code owner February 12, 2020 22:03

kkraus14 added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer Python Affects Python cuDF API. labels Feb 13, 2020

kkraus14 requested changes Feb 13, 2020

View reviewed changes

python/cudf/cudf/tests/test_stats.py Outdated Show resolved Hide resolved

python/cudf/cudf/tests/test_stats.py Outdated Show resolved Hide resolved

python/cudf/cudf/tests/test_stats.py Outdated Show resolved Hide resolved

kkraus14 added 0 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Feb 13, 2020

rnyak and others added 4 commits February 13, 2020 13:11

Update python/cudf/cudf/tests/test_stats.py

880e61d

Co-Authored-By: Keith Kraus <[email protected]>

Update python/cudf/cudf/tests/test_stats.py

baafce3

Co-Authored-By: Keith Kraus <[email protected]>

Update python/cudf/cudf/tests/test_stats.py

36308df

Co-Authored-By: Keith Kraus <[email protected]>

Update series.py

60ffe90

rnyak changed the title ~~[REVIEW] adding Corr() function inside dataframe.py to compute the correlation matrix of a data frame~~ [REVIEW] adding Corr() function inside dataframe.py to compute the correlation matrix of a data frame and adding examples in series.py Feb 13, 2020

Update test_stats.py

d672721

beckernick mentioned this pull request Feb 13, 2020

[FEA] libcudf Series correlation (Pearson) #1267

Open

rnyak added 3 commits February 17, 2020 11:15

Update CHANGELOG.md

2cb88d6

Add example of reading hex values as integers

9a04799

Update ioutils.py

8c05955

rnyak added 4 commits February 21, 2020 08:45

Update

8274577

Update

c75a83f

Update

50d0036

Update

9b578c9

kkraus14 reviewed Feb 21, 2020

View reviewed changes

python/cudf/cudf/utils/ioutils.py Outdated Show resolved Hide resolved

kkraus14 requested changes Feb 21, 2020

View reviewed changes

Update iloc() example

a755dba

kkraus14 requested changes Feb 21, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

python/cudf/cudf/utils/ioutils.py Outdated Show resolved Hide resolved

rnyak and others added 3 commits February 21, 2020 19:13

Update CHANGELOG.md

e90eca9

Co-Authored-By: Keith Kraus <[email protected]>

Update ioutils.py

29aa269

Update ioutils.py

ec7cff3

kkraus14 approved these changes Feb 24, 2020

View reviewed changes

kkraus14 added 3 - Ready for Review Ready for review by team doc Documentation and removed 0 - Waiting on Author Waiting for author to respond to review labels Feb 24, 2020

randerzander requested changes Mar 4, 2020

View reviewed changes

python/cudf/cudf/utils/ioutils.py Outdated Show resolved Hide resolved

rnyak added 2 commits March 4, 2020 09:23

Update ioutils.py

82308ef

Update ioutils.py

e6e539b

randerzander approved these changes Mar 4, 2020

View reviewed changes

karthikeyann approved these changes Mar 7, 2020

View reviewed changes

rnyak added 2 commits March 11, 2020 11:24

Update ioutils.py

6903856

Update CHANGELOG.md

539bb93

kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 11, 2020

Merge branch 'branch-0.13' into branch-0.13

5844786

kkraus14 merged commit 8de02da into rapidsai:branch-0.13 Mar 11, 2020

beckernick mentioned this pull request May 26, 2020

[FEA] DataFrame correlation #3675

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REVIEW] adding Corr() function inside dataframe.py to compute the correlation matrix of a data frame and adding examples in series.py #4140

[REVIEW] adding Corr() function inside dataframe.py to compute the correlation matrix of a data frame and adding examples in series.py #4140

rnyak commented Feb 12, 2020

codecov bot commented Feb 13, 2020 •

edited

Loading

rnyak commented Feb 19, 2020

kkraus14 left a comment

kkraus14 left a comment

randerzander left a comment

randerzander commented Mar 10, 2020

kkraus14 commented Mar 10, 2020

rnyak commented Mar 11, 2020

kkraus14 commented Mar 11, 2020

kkraus14 commented Mar 11, 2020

[REVIEW] adding Corr() function inside dataframe.py to compute the correlation matrix of a data frame and adding examples in series.py #4140

[REVIEW] adding Corr() function inside dataframe.py to compute the correlation matrix of a data frame and adding examples in series.py #4140

Conversation

rnyak commented Feb 12, 2020

codecov bot commented Feb 13, 2020 • edited Loading

Codecov Report

rnyak commented Feb 19, 2020

kkraus14 left a comment

Choose a reason for hiding this comment

kkraus14 left a comment

Choose a reason for hiding this comment

randerzander left a comment

Choose a reason for hiding this comment

randerzander commented Mar 10, 2020

kkraus14 commented Mar 10, 2020

rnyak commented Mar 11, 2020

kkraus14 commented Mar 11, 2020

kkraus14 commented Mar 11, 2020

codecov bot commented Feb 13, 2020 •

edited

Loading