Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RMM include files #3985

Merged

Conversation

jrhemstad
Copy link
Contributor

@jrhemstad jrhemstad commented Jan 29, 2020

Corresponds to rapidsai/rmm#262

@jrhemstad jrhemstad requested a review from a team as a code owner January 29, 2020 19:23
@devavret devavret added the libcudf Affects libcudf (C++/CUDA) code. label Jan 31, 2020
@jrhemstad
Copy link
Contributor Author

Now that rapidsai/rmm#262 is merged, it's just a waiting game until the cuDF CI picks up the new RMM conda package.

@dillon-cullinan
Copy link
Contributor

rerun tests

@kkraus14 kkraus14 added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Feb 3, 2020
@kkraus14 kkraus14 removed the request for review from kaatish February 3, 2020 20:44
Copy link
Contributor

@trevorsm7 trevorsm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #3985 into branch-0.13 will decrease coverage by 0.18%.
The diff coverage is 78.07%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.13    #3985      +/-   ##
===============================================
- Coverage        86.77%   86.58%   -0.19%     
===============================================
  Files               50       50              
  Lines             9718     9783      +65     
===============================================
+ Hits              8433     8471      +38     
- Misses            1285     1312      +27
Impacted Files Coverage Δ
python/cudf/cudf/utils/cudautils.py 44.73% <ø> (+0.07%) ⬆️
python/cudf/cudf/_libxx/__init__.py 100% <100%> (ø) ⬆️
python/cudf/cudf/core/index.py 89.31% <100%> (+0.18%) ⬆️
python/cudf/cudf/core/column/string.py 94.55% <100%> (+0.73%) ⬆️
python/cudf/cudf/core/series.py 92.33% <100%> (+0.01%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 96.23% <100%> (+0.14%) ⬆️
python/cudf/cudf/core/column/column.py 85.22% <33.33%> (-0.13%) ⬇️
python/cudf/cudf/core/multiindex.py 83.59% <48.27%> (-2.43%) ⬇️
python/cudf/cudf/core/frame.py 97.72% <83.33%> (-2.28%) ⬇️
python/cudf/cudf/core/dataframe.py 91.89% <85%> (-0.19%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a995d...f4329cc. Read the comment docs.

@jrhemstad jrhemstad added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Feb 3, 2020
@jrhemstad jrhemstad merged commit 5f13971 into rapidsai:branch-0.13 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants