WIP: Preferentially serialize Buffer as bytes
#3978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using pickle, objects like NumPy arrays may be transformed to `bytes` resulting in an additional copy. To avoid this try to go to `bytes` directly when possible. This should avoid that additional copy. If that fails, we can fallback to creating a NumPy array instead.
jakirkham
changed the title
Buffer as bytesBuffer as bytes
|
Seems like an even bigger reason to have an |
kkraus14
added
3 - Ready for Review
kkraus14
approved these changes
Jan 29, 2020
|
Happy to stick with this, but have an idea where we can benefit from this idea even when |
|
Closing this out based on this comment. |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pickle, objects like NumPy arrays may be transformed to
bytesresulting in an additional copy. To avoid this try to go tobytesdirectly when possible. This should avoid that additional copy. If that fails, we can fallback to creating a NumPy array instead.