-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new factory function : make_fixed_width_column() #3461
Add a new factory function : make_fixed_width_column() #3461
Conversation
…state as individual params instead of deriving them from an existing column. The use case for here is something like: out = copy_if_else(scalar, scalar, column boolean_mask) where the type is dictated by the scalar inputs, but the size is dictated by the boolean_mask column.
Instead of an unique_ptr<column> make_fixed_width_column(data_type type, size_type size, mask_state state, ...); I originally split As such, I'd just make this code into the new factory. |
…tion for fixed width types, make_fixed_width_column.
Codecov Report
@@ Coverage Diff @@
## branch-0.12 #3461 +/- ##
============================================
Coverage 87.35% 87.35%
============================================
Files 49 49
Lines 9329 9329
============================================
Hits 8149 8149
Misses 1180 1180 Continue to review full report at Codecov.
|
…make_numeric_column.
…d<> for null_mask reference.
Just realized this is in branch-0.12. Is it needed in branch-0.11? |
Adds an overload to allocate_like() that takes raw inputs instead of deriving from an input column. The primary use case for this is callers of the form:
where the type of the output column is derived from the scalar inputs, but the size comes from the column input. Concrete example: