Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Port NVStrings regex replace functions to cudf strings column #3409

Merged
merged 31 commits into from
Jan 17, 2020
Merged

[REVIEW] Port NVStrings regex replace functions to cudf strings column #3409

merged 31 commits into from
Jan 17, 2020

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Nov 18, 2019 •
edited
Loading

Porting NVStrings replace functions that use regex to cudf strings column:

replace_re()
replace_multi()
replace_with_backrefs()

Depends on #3292 for the base regex code.

@davidwendt davidwendt requested review from a team as code owners November 18, 2019 22:40
@davidwendt davidwendt self-assigned this Nov 18, 2019
@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf++ strings strings issues (C++ and Python) labels Nov 18, 2019
@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited
Loading

Codecov Report

Merging #3409 into branch-0.12 will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-0.12   #3409      +/-   ##
==============================================
+ Coverage        86.66%   86.7%   +0.04%     
==============================================
  Files               50      50              
  Lines             9601    9601              
==============================================
+ Hits              8321    8325       +4     
+ Misses            1280    1276       -4
Impacted Files Coverage Δ
python/cudf/cudf/io/avro.py 80% <0%> (+40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572a5c9...74dcfe4. Read the comment docs.

@davidwendt davidwendt changed the title [WIP] Port NVStrings regex replace functions to cudf strings column [REVIEW] Port NVStrings regex replace functions to cudf strings column Nov 20, 2019
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 20, 2019
@harrism harrism requested a review from codereport December 4, 2019 05:09
@harrism
Copy link
Member

harrism commented Dec 4, 2019

Move to 0.12

@harrism harrism changed the base branch from branch-0.11 to branch-0.12 December 4, 2019 05:09
@davidwendt
Copy link
Contributor Author

rerun tests

codereport
codereport suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of backref_re.cu, will follow up with review of other files

cpp/src/strings/replace/backref_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/backref_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/backref_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/backref_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/backref_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/backref_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/backref_re.cu Outdated Show resolved Hide resolved
@codereport codereport mentioned this pull request Jan 14, 2020
Closed
codereport
codereport suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple small comments about comma operator. There are a couple things I would modify but they have already been mentioned in the follow up clean up :)

cpp/src/strings/replace/multi_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/multi_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/replace_re.cu Outdated Show resolved Hide resolved
cpp/src/strings/replace/replace_re.cu Outdated Show resolved Hide resolved
@codereport codereport added the 0 - Waiting on Author Waiting for author to respond to review label Jan 14, 2020
codereport
codereport approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@davidwendt davidwendt added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 0 - Waiting on Author Waiting for author to respond to review labels Jan 17, 2020
@jrhemstad jrhemstad merged commit 70b1df0 into rapidsai:branch-0.12 Jan 17, 2020
@davidwendt davidwendt deleted the port-nvs-regex-replace branch January 17, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codereport codereport codereport approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

Assignees

@davidwendt davidwendt

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @harrism @jrhemstad @codereport