[REVIEW] Invalid children check in mutable_column_device_view #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
approved these changes
Nov 1, 2019
Codecov Report
@@ Coverage Diff @@
## branch-0.11 #3280 +/- ##
============================================
Coverage 87.13% 87.13%
============================================
Files 49 49
Lines 9269 9269
============================================
Hits 8077 8077
Misses 1192 1192Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Children are not supported for mutable_column_device_view. The CUDF_EXPECTS check for this was incorrect and fixed by this PR.